Comment on attachment 721595 [details] [diff] [review] WebIDL API for PointLight Review of attachment 721595 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/svg/content/src/SVGFEPointLightElement.cpp @@ +11,5 @@ > namespace mozilla { > namespace dom { > > +JSObject* > +SVGFEPointLightElement::WrapNode(JSContext *aCx, JSObject *aScope, bool *aTriedToWrap) * to the left ::: content/svg/content/src/SVGFEPointLightElement.h @@ +27,5 @@ > + : SVGFEPointLightElementBase(aNodeInfo) > + { > + SetIsDOMBinding(); > + } > + virtual JSObject* WrapNode(JSContext *cx, JSObject *scope, bool *triedToWrap) MOZ_OVERRIDE; * to the left and aFoo ::: content/svg/content/src/nsSVGFilters.cpp @@ +3333,5 @@ > aVal = std::max(aVal, 0); > return std::min(aVal, aMax - 1); > } > > +static int32_t WrapInterval(int32_t aVal, int32_t aMax) Was this broken in the previous patch?

(In reply to :Ms2ger from comment #3) > > Was this broken in the previous patch? This part got deleted in a different patch. remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/74ff58a4b51d remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/36094d21286a

https://hg.mozilla.org/mozilla-central/rev/74ff58a4b51d https://hg.mozilla.org/mozilla-central/rev/36094d21286a

Comment on attachment 724626 [details] [diff] [review] WebIDL API for FEDistantLight Review of attachment 724626 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/svg/content/src/SVGFEDistantLightElement.cpp @@ +11,5 @@ > +namespace mozilla { > +namespace dom { > + > +JSObject* > +SVGFEDistantLightElement::WrapNode(JSContext *aCx, JSObject *aScope, bool *aTriedToWrap) * to the left @@ +66,5 @@ > +//---------------------------------------------------------------------- > +// nsSVGElement methods > + > +nsSVGElement::NumberAttributesInfo > +SVGFEDistantLightElement::GetNumberInfo() Just don't remove this in the previous patch.

remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/11a2ae73e705 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/9606fa13b8e3

https://hg.mozilla.org/mozilla-central/rev/11a2ae73e705 https://hg.mozilla.org/mozilla-central/rev/9606fa13b8e3 https://hg.mozilla.org/mozilla-central/rev/88ca40b7feeb