Closed Bug 832272 Opened 12 years ago Closed 12 years ago

To allow parallel build of nss

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: stransky, Assigned: glandium)

References

Details

Attachments

(4 files, 7 obsolete files)

Attached patch patch (deleted) — Splinter Review
This patch allows me to build NSS by parallel.
(In reply to Martin Stránský from comment #0) > Created attachment 703856 [details] [diff] [review] > patch > > This patch allows me to build NSS by parallel. Does this work when building NSS outside the mozilla tree?
Have not tried, I use it for building trunk with in-tree nss.
Seems like it doesn't work for standalone NSS :(
Honza, do you build on Linux or Windows? Which build failures do you get? I guess it could be adapted for standalone NSS.
Attached file build-log (deleted) —
(In reply to Martin Stránský from comment #4) > Honza, do you build on Linux or Windows? Which build failures do you get? I > guess it could be adapted for standalone NSS. I'm using following build commands: OS_TARGET=WINNT BUILD_OPT=1 cd mozilla/security/nss pymake nss_build_all (-j9) win7, 1.6.1 mozilla-build, using VC10. pymake nss_build_all: following non-critical errors, the build actually succeeds!: Error executing command ../../config/./now [Error 2] The system cannot find the file specified Error executing command ../../config/./now [Error 2] The system cannot find the file specified Error executing command ../../config/./now [Error 2] The system cannot find the file specified Error executing command ../../config/./now [Error 2] The system cannot find the file specified Error executing command ../../../config/./now [Error 2] The system cannot find the file specified Error executing command ../../../config/./now [Error 2] The system cannot find the file specified pymake nss_build_all -j9: build fails and see the attachment for a complete log build (win stdout)
Attached patch Allow mostly parallel build of NSS (obsolete) (deleted) — Splinter Review
Attachment #707040 - Flags: review?(ted)
Assignee: nobody → mh+mozilla
Component: Build → Build Config
Product: NSS → Core
Version: trunk → Trunk
OS: Linux → All
Hardware: x86_64 → All
Attachment #707044 - Flags: review?(kaie)
Attached patch Allow mostly parallel build of NSS (obsolete) (deleted) — Splinter Review
Attachment #707071 - Flags: review?(ted)
Attachment #707040 - Attachment is obsolete: true
Attachment #707040 - Flags: review?(ted)
Comment on attachment 707044 [details] [diff] [review] Avoid certdata.c being created before $(OBJDIR) is seems reasonable! r=kaie
Attachment #707044 - Flags: review?(kaie) → review+
(In reply to Honza Bambas (:mayhemer) from comment #5) > > I'm using following build commands: > OS_TARGET=WINNT Honza, note that WINNT is an older configuration that has problems. The more modern config is named WIN95, and WIN95 is being used by Firefox.
(In reply to Kai Engert (:kaie) from comment #9) > Comment on attachment 707044 [details] [diff] [review] > Avoid certdata.c being created before $(OBJDIR) is > > seems reasonable! r=kaie Could you land it in NSS?
Attachment #707071 - Flags: review?(ted) → review+
Attached patch Allow mostly parallel build of NSS (obsolete) (deleted) — Splinter Review
This is a more elaborate version, which doesn't need any nss change, and that prepares things for bug 648407.
Attachment #710209 - Flags: review?(ted)
Attachment #707071 - Attachment is obsolete: true
Comment on attachment 710209 [details] [diff] [review] Allow mostly parallel build of NSS Must have forgotten to fold something in this patch...
Attachment #710209 - Flags: review?(ted)
Attached patch Allow mostly parallel build of NSS (obsolete) (deleted) — Splinter Review
This passes try ; i'll send another try with PGO enabled, though.
Attachment #710645 - Flags: review?(ted)
Attachment #710209 - Attachment is obsolete: true
Attached patch Allow mostly parallel build of NSS (obsolete) (deleted) — Splinter Review
Only changes some variable names.
Attachment #710669 - Flags: review?(ted)
Attachment #710645 - Attachment is obsolete: true
Attachment #710645 - Flags: review?(ted)
Attached patch Allow mostly parallel build of NSS (obsolete) (deleted) — Splinter Review
Sorry for the noise ; added a comment about the private_export thing.
Attachment #710678 - Flags: review?(ted)
Attachment #710669 - Attachment is obsolete: true
Attachment #710669 - Flags: review?(ted)
Blocks: 648407
Attached patch Allow mostly parallel build of NSS (obsolete) (deleted) — Splinter Review
Just changed paths for the DLLs (dist/bin instead of dist/lib)
Attachment #711259 - Flags: review?(ted)
Attachment #710678 - Attachment is obsolete: true
Attachment #710678 - Flags: review?(ted)
Comment on attachment 711259 [details] [diff] [review] Allow mostly parallel build of NSS Grah, it's broken
Attachment #711259 - Attachment is obsolete: true
Attachment #711259 - Flags: review?(ted)
Attachment #711316 - Flags: review?(ted)
Comment on attachment 711316 [details] [diff] [review] Allow mostly parallel build of NSS Review of attachment 711316 [details] [diff] [review]: ----------------------------------------------------------------- I assume your intention is to remove these workarounds once real fixes land? I don't love this, but the payoff is nice. Hopefully the NSS build system will be improved and we won't have to work around it so much.
Attachment #711316 - Flags: review?(ted) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Comment on attachment 707044 [details] [diff] [review] Avoid certdata.c being created before $(OBJDIR) is https://hg.mozilla.org/projects/nss/rev/514f784e0402
Attachment #707044 - Flags: review+
Attachment #707044 - Flags: checkin+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: