Closed
Bug 832472
Opened 12 years ago
Closed 12 years ago
pymake mtime comparisons can fail on things that were installed with nsinstall.py
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla21
People
(Reporter: khuey, Assigned: khuey)
References
(Blocks 1 open bug)
Details
(Whiteboard: [buildfaster:p1])
Attachments
(1 file)
|
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
|
||
Comment 1•12 years ago
|
||
Comment on attachment 704062 [details] [diff] [review] Patch I'll help Ted out here :) Could you please add an in-line comment linking to the Python issue? An automated test would also be nice. You can't do a full test because of race conditions. But, a manual os.utime with values <0.001 apart should be sufficient.
Attachment #704062 -
Flags: review?(ted) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/2b564a476b70 https://hg.mozilla.org/integration/mozilla-inbound/rev/9026afc4dc20
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9026afc4dc20
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•12 years ago
|
Blocks: build-perf, 755684
Whiteboard: [buildfaster:p1]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•