Closed
Bug 832679
Opened 12 years ago
Closed 12 years ago
AppMenu: Menu checkmarks indicating if {Folder pane} or {Message Pane} are shown or hidden work the wrong way round (Options > Layout)
Categories
(Thunderbird :: Toolbars and Tabs, defect)
Tracking
(thunderbird20 fixed, thunderbird-esr1720+ fixed)
RESOLVED
FIXED
Thunderbird 21.0
People
(Reporter: Mikeyy, Assigned: Paenglab)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mconley
:
review+
standard8
:
approval-comm-beta+
standard8
:
approval-comm-esr17+
|
Details | Diff | Splinter Review |
TB 17.0.2, Win7 64bit, croatian locale
Make sure you have "CLASSIC VIEW" and folder and message panes showing on you TB.
Click:
APP MENU BUTTON / OPTIONS / LAYOUT
Take a look at 2 last options:
Folder Pane
Message Pane
You will not see any marks that those 2 are turned on (if you have them visible, which is default for TB).
If you press ALT to show old menu, then go VIEW / LAYOUT, you will see that those same 2 last options have been marked as turned ON, which wasn't case in APP BUTTON menu.
Reporter | ||
Updated•12 years ago
|
Comment 1•12 years ago
|
||
confirming on winxp/tb17.02, exactly as described.
The inital state of the checkmarks is wrong, hence the get toggled the wrong way round:
- no checkmarks when Panes are shown (wrong)
- checkmarks when Panes are hidden (wrong)
:Paenglab, this should be a simple fix, suppose you could just copy the logic from the traditional menu where respective checkmarks work correctly.
Blocks: TB-AppMenu
Severity: normal → minor
Status: UNCONFIRMED → NEW
Component: General → Toolbars and Tabs
Ever confirmed: true
Flags: needinfo?
OS: Windows 7 → All
Hardware: x86_64 → All
Summary: APP BUTTON MENU bug: Not correctly showing on/off marks → AppMenu: Menu checkmarks indicating if {Folder pane} or {Message Pane} are shown or hidden work the wrong way round (Options > Layout)
Comment 2•12 years ago
|
||
(In reply to Thomas D. from comment #1)
> confirming on winxp/tb17.02, exactly as described.
>
> The inital state of the checkmarks is wrong, hence the get toggled the wrong
> way round:
>
> - no checkmarks when Panes are shown (wrong)
> - checkmarks when Panes are hidden (wrong)
>
> :Paenglab, this should be a simple fix, suppose you could just copy the
> logic from the traditional menu where respective checkmarks work correctly.
^^
Flags: needinfo? → needinfo?(richard.marti)
Assignee | ||
Comment 3•12 years ago
|
||
Adding the main menu logic to the menuitems in AppMenu.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #704303 -
Flags: review?(mconley)
Flags: needinfo?(richard.marti)
Comment 4•12 years ago
|
||
Comment on attachment 704303 [details] [diff] [review]
patch
Review of attachment 704303 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry for the delay - looks good!
Attachment #704303 -
Flags: review?(mconley) → review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 704303 [details] [diff] [review]
patch
[Approval Request Comment]
This would make the checkmark behavior of this menuitems correct in AppMenu. The patch is only a code copy from main menu to the new items and shouldn't add new issues.
Attachment #704303 -
Flags: approval-comm-esr17?
Attachment #704303 -
Flags: approval-comm-beta?
Attachment #704303 -
Flags: approval-comm-aurora?
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 21.0
Comment 7•12 years ago
|
||
Comment on attachment 704303 [details] [diff] [review]
patch
Already in 21, so a=me for beta & esr17.
Attachment #704303 -
Flags: approval-comm-esr17?
Attachment #704303 -
Flags: approval-comm-esr17+
Attachment #704303 -
Flags: approval-comm-beta?
Attachment #704303 -
Flags: approval-comm-beta+
Attachment #704303 -
Flags: approval-comm-aurora?
Comment 8•12 years ago
|
||
status-thunderbird20:
--- → fixed
Comment 9•12 years ago
|
||
status-thunderbird-esr17:
--- → fixed
tracking-thunderbird-esr17:
--- → 20+
You need to log in
before you can comment on or make changes to this bug.
Description
•