Closed Bug 832878 Opened 12 years ago Closed 12 years ago

[Bluetooth] Unable to open image with MIME type "image/*"

Categories

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: echou, Assigned: iliu)

Details

Attachments

(1 file)

Device: Unagi Build: latest b2g18 build STR: 1. Make Unagi paired with remote Android 4.2.1 device (I use Galaxy Nexus). 2. Send a photo to Galaxy Nexus. 3. After transferring is done, click the notification and send the same photo back to Unagi. 4. After transferring is done, click the notification on Unagi to open the photo, error message "Can not open unknown media type" would be displayed.
To prevent this error from happening, we should use file extension to decide the content type of the file, and use the content type sent from remote device as a backup if there is no valid file extension.
It looks like a special case which is needed to handle by Bluetooth app. We should consider the specific MIME type "image/*", then parse its file extension to find out correctly one.
Assignee: nobody → iliu
Comment on attachment 707991 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7858 David, Could you please help to review my pr? It's about to open a received file with content type "image/*". Thank you.
Attachment #707991 - Flags: review?(dflanagan)
Comment on attachment 707991 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7858 Looks good to me. r+. You could also solve this bug by changing apps/gallery/manifest.webapp to make the gallery open activity accept the literal mimetype 'image/*'. Or we could even use the new activities filter syntax (I'd have to look it up, I forget) to specify a regular expression so it would accept any mime type that begins with "image/". That might actually be the cleaner way to fix this. On the other hand, you have a fix that works right now, so it would be easiest to just land what you have.
Attachment #707991 - Flags: review?(dflanagan) → review+
(In reply to David Flanagan [:djf] from comment #5) > Comment on attachment 707991 [details] > Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7858 > > Looks good to me. r+. > > You could also solve this bug by changing apps/gallery/manifest.webapp to > make the gallery open activity accept the literal mimetype 'image/*'. Yes, it could be a good way to fix the issue. But I want to pre-check that the mimetype is available or not before sending the "open" activity request. It will avoid user to enter Gallery open view with an unavailable mimetype as possible as we can. > > Or we could even use the new activities filter syntax (I'd have to look it > up, I forget) to specify a regular expression so it would accept any mime > type that begins with "image/". That might actually be the cleaner way to > fix this. On the other hand, it will make Gallery -> open to receive other mimetype which are not supported now. > > On the other hand, you have a fix that works right now, so it would be > easiest to just land what you have. Thanks for your reviewing effort and suggestion. :)
https://github.com/mozilla-b2g/gaia/pull/7858 Since the pr is merged, we can close the issue now.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Gaia: 0f1f1ab0ab31a1df8a780baa048b5e7b2854205d B-D 2013-08-15 06:32:03 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/692d3414bb12 BuildID 20130815041201 Version 18.0
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: