Closed
Bug 832958
Opened 12 years ago
Closed 6 years ago
Workers: Switch from AutoSafeJSContext to mozilla::SafeAutoJSContext
Categories
(Core :: DOM: Workers, defect, P5)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
People
(Reporter: mounir, Unassigned)
References
Details
mozilla::SafeAutoJSContext has been introduced in bug 828472 and could be used instead of the AutoSafeJSContext defined in Workers code.
|
Reporter | |
Comment 1•12 years ago
|
||
Looking at AutoSafeJSContext a bit more, I realise it's not really as trivial because AutoSafeJSContext can take a context in ctor parameter and will do push and pop. mozilla::AutoJSContext just returns a context. It will do push and pop if it is a safe context.
|
||
Comment 2•12 years ago
|
||
Yeah if it's nontrivial it's probably not a very high priority. This whole mechanism is already on its way out.
(In reply to Mounir Lamouri (:mounir) from comment #0)
> mozilla::SafeAutoJSContext has been introduced in bug 828472 and could be
> used instead of the AutoSafeJSContext defined in Workers code.
Thanks for the heads up! If bholley can get rid of JSContexts altogether I'd be happier, but I can look at this sometime.
|
||
Updated•7 years ago
|
Priority: -- → P5
|
||
Comment 4•6 years ago
|
||
SafeAutoJSContext is not a thing anymore. AutoSafeJSContext is a thing (though not defined in worker code), but not used on workers.
Resolving fixed, I guess, since we no longer use the worker-specific AutoSafeJSContext.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•