Closed
Bug 833004
Opened 12 years ago
Closed 12 years ago
Can't start Tilt
Categories
(Firefox Graveyard :: Developer Tools: 3D View, defect, P1)
Tracking
(firefox19 unaffected, firefox20+ verified, firefox21 verified)
RESOLVED
FIXED
Firefox 21
Tracking | Status | |
---|---|---|
firefox19 | --- | unaffected |
firefox20 | + | verified |
firefox21 | --- | verified |
People
(Reporter: paul, Assigned: vporof)
References
Details
Attachments
(1 file)
(deleted),
patch
|
paul
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
STR: - open a new window - start the inspector - start tilt - close the toolbox - press ESC to stop tilt - start the inspector - see Tilt button being active (it should not) - click on Tilt button - Tilt doesn't start (it should)
Reporter | ||
Updated•12 years ago
|
Blocks: DevToolsPaperCuts
Assignee | ||
Comment 1•12 years ago
|
||
Timestamp: 1/21/13 7:01:55 PM Error: TypeError: this.inspector.selection is null Source File: resource://gre/modules/devtools/TiltVisualizer.jsm Line: 197 ..when tilt is closed via ESC after closing the toolbox.
No longer blocks: DevToolsPaperCuts
Assignee | ||
Updated•12 years ago
|
Blocks: DevToolsPaperCuts
Reporter | ||
Comment 2•12 years ago
|
||
cc'ing Optimizer, as I think it's related to how we handle the toggle state of the Tilt button.
Comment 3•12 years ago
|
||
I think that since the TiltVisualizer gave an exception, it does not restarts as the script has already exception-ed out. The problem is basically that inspector.selecito is alredy gone by the time TileVisualizer tries to remove an event handler.
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Girish Sharma [:Optimizer] from comment #3) > I think that since the TiltVisualizer gave an exception, it does not > restarts as the script has already exception-ed out. > > The problem is basically that inspector.selecito is alredy gone by the time > TileVisualizer tries to remove an event handler. Wanna fix it? :)
Reporter | ||
Comment 5•12 years ago
|
||
This is pretty bad. We want to fix that in Firefox Aurora (firefox 20).
Priority: -- → P1
Assignee | ||
Comment 6•12 years ago
|
||
Ok.
Reporter | ||
Comment 7•12 years ago
|
||
Comment on attachment 704892 [details] [diff] [review] v1 Thank you Victor.
Attachment #704892 -
Flags: review?(paul) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/9225e25e3f1e
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Assignee | ||
Comment 9•12 years ago
|
||
Comment on attachment 704892 [details] [diff] [review] v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): Users won't be able to start the 3D view in some cases User impact if declined: medium for developers, small for regular users Testing completed (on m-c, etc.): fx-team Risk to taking this patch (and alternatives if risky): none String or UUID changes made by this patch: none
Attachment #704892 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9225e25e3f1e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 21
Updated•12 years ago
|
Updated•12 years ago
|
Attachment #704892 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 11•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/bd00c6ae955e
Updated•12 years ago
|
Updated•12 years ago
|
relnote-firefox:
--- → ?
Updated•12 years ago
|
status-firefox19:
--- → unaffected
relnote-firefox:
? → ---
Comment 12•12 years ago
|
||
Verified as fixed on: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:20.0) Gecko/20100101 Firefox/20.0 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0 Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0
Comment 13•11 years ago
|
||
Verified as fixed on Firefox 21 RC - 20130507015204.
Updated•11 years ago
|
No longer blocks: DevToolsPaperCuts
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•