Closed
Bug 833460
Opened 12 years ago
Closed 12 years ago
saved ping files shouldn't be read in profile-after-change
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: froydnj, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Telemetry:P1])
Attachments
(1 file)
(deleted),
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
There are at least two things that can/should be done here:
1) Move reading ping files out of the main startup path. Reading the files can be expensive, and there can be several of them, which only adds to hurt.
2) Make reading ping files async.
This bug is more about #1.
Updated•12 years ago
|
Blocks: start-faster
Whiteboard: [Telemetry:P1] → [Telemetry:P1][
Updated•12 years ago
|
Whiteboard: [Telemetry:P1][ → [Telemetry:P1]
Reporter | ||
Comment 1•12 years ago
|
||
Just delay reading the pings until we hook everything up. Individual pings
are already read async, so no need to tweak that.
Attachment #705052 -
Flags: review?(taras.mozilla)
Comment 2•12 years ago
|
||
Comment on attachment 705052 [details] [diff] [review]
move reading saved pings to the timer-based callback
ok for short term fix. We should load them on the demand as we send them in the future.
Attachment #705052 -
Flags: review?(taras.mozilla) → review+
Reporter | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
Wow, that was amazingly fast. :-D How do you guys typically measure the effect of landing a startup patch like this?
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•