Closed Bug 83349 Opened 24 years ago Closed 22 years ago

need to remove Debug menu from Composer

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: rubydoo123, Assigned: jag+mozilla)

References

Details

(Whiteboard: [adt1] fixed1.3 branch, next up 1.4 branch)

Attachments

(1 file)

Patch for bug
(deleted), patch
Details | Diff | Splinter Review
Summary says it all
We probably want to make this change right after branching 0.9.1 (change the branch only.) That is what we've done in the past.
Hardware: PC → All
Attached patch Patch for bug (deleted) — — Splinter Review
I would suggest *only* removing it from editor.xul, not editorOverlay.xul. Other xul files might include it and this would cause an error. r=cmanske for the editor.xul change.
Status: NEW → ASSIGNED
Can you please hold off on this change until m0.9.2? It would help us greatly to get out int'l betas out as scheduled.
Thanks for your input cmanske, I got rid of the editorOverlay.xul changes. ...how does hiding the debug menu affect i18n?
Thanks for your input cmanske, I got rid of the editorOverlay.xul changes. ...how does hiding the debug menu affect i18n?
sr=sfraser for the editor.xul change only.
This change should not affect i18n.
a= asa@mozilla.org for checkin to 0.9.1
editor.xul part of patch checked in. Ryan asked me to do this.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
This was checked in on the trunk. I was under the impression this would be a branch-only fix? Isn't the debug menu used during development any longer?
Correct, this should not have been checked in on the trunk. Supposed to be in branch only!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
We need to simply restore the debug menu in trunk so testors can utilize the Debug menu commands.
Status: REOPENED → ASSIGNED
Whiteboard: FIX IN HAND
Target Milestone: --- → mozilla0.9.2
Blocks: 83989
great! a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Whiteboard: FIX IN HAND → fixed, reviewed, a=asa
Debug menu restored for testing. Remember to remove before RTM!] Bug kept open for that task.
Whiteboard: fixed, reviewed, a=asa
handing over to brade
Assignee: cmanske → brade
Status: ASSIGNED → NEW
OS: Windows 98 → All
Whiteboard: fix in hand; waiting for branch
this fix is now in the 0.9.2 branch. Resetting milestone to 1.0 for removal in later builds.
Target Milestone: mozilla0.9.2 → mozilla1.0
spam composer change
Component: Editor: Core → Editor: Composer
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0.1 → mozilla1.0
Keywords: nsbeta1+
removing myself from the cc list
Keywords: adt1.0.0
Whiteboard: fix in hand; waiting for branch → fix in hand; waiting for branch [adt1]
adt1.0.0+ (on behalf of ADT) for checkin into 1.0. Pls do this after we branch.
Keywords: adt1.0.0 → adt1.0.0+
This fix has been checked into the mozilla 1.0 branch, removing adt1.0.0+ so it doesn't show up on that radar. Reset milestone to mozilla1.1alpha.
Keywords: adt1.0.0+
Target Milestone: mozilla1.0 → mozilla1.1alpha
reset adt1.0.0+ and add fixed1.0.0 keyword (hopefully that's the right magic)
Keywords: adt1.0.0+, fixed1.0.0
remove [adt1] since we don't want this showing up on the radar (it was checked in for branch already)
Whiteboard: fix in hand; waiting for branch [adt1] → fix in hand; waiting for branch
if this is resolved/fixed on the trunk, and fixed1.0.0, it should not show up on the ADT's radar. pls do not remove adt Status Whiteboard markings.
URL: [adt1]
Sujay - Can you please verify this one on the 1.0 branch, then add the verified1.0.0 keyword? thanks!
verified in 4/25 branch build. I cannot verify this on the trunk until it is marked RESOLVED-FIXED.
Keywords: verified1.0.0
Target Milestone: mozilla1.1alpha → mozilla1.1beta
Target Milestone: mozilla1.1beta → mozilla1.3beta
-->jag Jag--this patch lands on every branch (typically right before final lockdown) It's pretty simple (commenting out the debug menu). The debug menu is useful in Composer for debugging purposes so we like to leave it in as long as possible. Let me know if you have any questions.
Assignee: brade → jaggernaut
Status: ASSIGNED → NEW
-> 1.3 final (or as soon as we branch for 1.3)
Target Milestone: mozilla1.3beta → mozilla1.3final
Adding this as a blocker to remind me we need to remove this. Maybe one of these days when we start using a XUL preprocessor we could add a #ifndef MOZILLA_RELEASE (or whatever) rule for these debug menus.
Flags: blocking1.3+
Checked in on 1.3 branch
Flags: blocking1.3+
URL: [adt1]
Whiteboard: fix in hand; waiting for branch → [adt1] Checked in on 1.3 branch, next up 1.4 branch
Whiteboard: [adt1] Checked in on 1.3 branch, next up 1.4 branch → [adt1] fixed1.3 branch, next up 1.4 branch
Target Milestone: mozilla1.3final → ---
Given to leaf, who said "close it".
Status: NEW → RESOLVED
Closed: 24 years ago → 22 years ago
Resolution: --- → FIXED
Verified in the Macho 2003-06-04-08 trunk and 2003-06-04-05 branch builds.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: