Closed Bug 83355 Opened 23 years ago Closed 17 years ago

[xlib] Xlib port doesn't use MIT-SHM extension

Categories

(Core :: XUL, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: timecop, Assigned: roland.mainz)

References

()

Details

Attachments

(2 files)

XlibRGB does not use SHM. gfx/src/xlib doesn't use SHM either. Making some patches later today.
This makes xlibrgb use MIT-SHM extension if available. This is a "add only" patch, no code has been changed or removed. The entire thing is under #ifdef MOZ_USE_SHM. It has been tested on little endian hardware, though if I followed the logic correctly it should work on either endian. Reviews are welcome.
The code still relies on XFlush() to be sure that the image has been rendered... the correct way should be to listen to XShmCompletionEvent events... Misc: - Setting dependicy to bug 57820 which plays around a little bit with xlibrgb.c - Added this bug to the Xlib-toolkit tracking bug (bug 79119)... - CC:'ing Xlib-toolkit folks
Blocks: 79119
Depends on: 57820
hi gisburn :) I am going on vacation and you love MIT-SHM :)
Assignee: timecop → Roland.Mainz
Yes, I do... :-) Accepting...
Status: NEW → ASSIGNED
Setting target milestone to 0.9.4(=soon :-)
Target Milestone: --- → mozilla0.9.4
Depends on: 94569
imoT: AFAIK you have a nice patch which kills XCreateGC() in xlibrgb.c ... wanna attach it here, please ? I'd like to include that in this patch, please...
Does that patch really work with 1bit deep StaticGray visuals (e.g. WeiredX JAVA server or WiredX (http://www.wiredx.com/) JAVA Xserver) ?
Sorry... that is http://www.wiredx.net/ ... :-)
Summary: Xlib port doesn't use MIT-SHM extension → [xlib] Xlib port doesn't use MIT-SHM extension
May God have mercy on us all. The 212 bug spam-o-rama is Now!
QA Contact: aegis → jrgm
0.9.4 is out the door.
Target Milestone: mozilla0.9.4 → mozilla0.9.5
0.9.5 is out the door. bumping TM up by one.
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Too late for 0.9.6, this needs retargeting.
Target Milestone: mozilla0.9.6 → mozilla0.9.7
cmon, roland, this has been sitting here for months. can't be that hard to forward-port this patch into current tree
I am on it... right now...
Adding testcase...
Depends on: 112635
pocemit: The final patch is in bug 112635, incl. support for MIT-SHM. Wanna r= it, please ?
Depends on: 113743
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Main patch "in" as part of patch in bug 112635. MIT-SHM support is currently |#ifdef'ed| out as it causes color issues on LSB machines... I'll take a look at that issue in 0.9.9 ...
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Target Milestone: mozilla0.9.9 → ---
Xlib port has been removed from trunk (bug 326152) -> WONTFIX
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: