Closed
Bug 834113
Opened 12 years ago
Closed 11 years ago
[OPEN_][Bluetooth] we can not view the Bluetooth address in settings.(617001980873)
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(b2g18+)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g18 | + | --- |
People
(Reporter: Firefox_Mozilla, Assigned: bruhuang)
References
Details
(Whiteboard: [MZ][good first bug][mentor=ehung][mentor-lang=zh][device-required])
Attachments
(2 files)
Bluetooth Address Mock Up
Steps to reproduce:
1. go into the settings;
2. try to view the Bluetooth address;
Expected results:
we can check the Bluetooth address;
Actual results:
the device does not have the menu to check or view Bluetooth address;
|
||
Comment 2•12 years ago
|
||
add tracking flag for next version consideration
tracking-b2g18:
--- → 19+
Flags: needinfo?(jcheng)
|
Reporter | |
Updated•12 years ago
|
OS: Windows XP → Gonk (Firefox OS)
Hardware: x86 → ARM
|
|
||
Updated•12 years ago
|
Group: mozilla-corporation-confidential
|
||
Updated•12 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
||
Updated•12 years ago
|
Assignee: nobody → khu
|
|
||
Comment 3•12 years ago
|
||
It sounds like a feature request to me.
|
||
Updated•12 years ago
|
|
|
Reporter | |
Updated•12 years ago
|
Whiteboard: [MZ]
|
|
||
Updated•12 years ago
|
Assignee: khu → echou
blocking-b2g: --- → koi?
|
||
Comment 4•12 years ago
|
||
Privileged Gaia apps can get Bluetooth address of local device via |defaultAdapter.address|. This should be a Gaia/Settings feature. Redirect to Evelyn, the owner of Settings app.
Assignee: echou → ehung
Component: Gaia::Bluetooth File Transfer → Gaia::Settings
|
||
Comment 5•12 years ago
|
||
It's easy to add this item in Settings, but we need UX input to define a correct place.
Flags: needinfo?(firefoxos-ux-bugzilla)
|
||
Comment 6•12 years ago
|
||
Reassigning to Eric (while Rob is out and we're short on help) for input on placement in Settings.
Flags: needinfo?(firefoxos-ux-bugzilla)
|
|
||
Updated•12 years ago
|
Flags: needinfo?(epang)
|
||
Comment 7•12 years ago
|
||
my suggestion would be to add the bluetooth address within 'More Information' in settings above the 'reset device' button.
Also, i'm not sure if this is being taken care of in another bug, but can we increase the space between the label and detail info? Right now it's looking very tight. I've mocked it up to have a 16px spacing from baseline to baseline. Thanks!
Flags: needinfo?(epang)
|
||
Comment 8•11 years ago
|
||
Push to v1.3 as v1.2 have already feature frozen.
Joe?
blocking-b2g: koi? → 1.3?
Flags: needinfo?(jcheng)
|
|
||
Comment 10•11 years ago
|
||
Triage: push to backlog as this is not a critical feature.
|
|
||
Updated•11 years ago
|
|
|
||
Updated•11 years ago
|
Whiteboard: [MZ][good first bug][mentor=ehung] → [MZ][good first bug][mentor=ehung][mentor-lang=zh]
|
||
Comment 11•11 years ago
|
||
Is this a good-first-bug and requiring device to verified? If so, I want to tag it in the whiteboard.
Flags: needinfo?(timdream)
|
|
||
Comment 12•11 years ago
|
||
(In reply to Greg Weng [:snowmantw] from comment #11)
> Is this a good-first-bug and requiring device to verified? If so, I want to
> tag it in the whiteboard.
Yes, Bluetooth API is only available on actual device, not on B2G/Desktop nor emulator AFIAK.
Flags: needinfo?(timdream)
|
|
||
Updated•11 years ago
|
Whiteboard: [MZ][good first bug][mentor=ehung][mentor-lang=zh] → [MZ][good first bug][mentor=ehung][mentor-lang=zh][device-required]
|
Assignee | |
Comment 13•11 years ago
|
||
Add Bluetooth address to settings based on UX proposal in comment 7.
|
|
Assignee | |
Comment 14•11 years ago
|
||
Hi Evelyn, tried to take a stab at this in comment 13, is it alright for me to take this bug off your hands? Thanks.
Flags: needinfo?(ehung)
|
|
||
Comment 15•11 years ago
|
||
(In reply to bruce <bruhuang@gmail.com> from comment #14)
> Hi Evelyn, tried to take a stab at this in comment 13, is it alright for me
> to take this bug off your hands? Thanks.
Sure, I'm reviewing your patch in comment 13. Please do flag a reviewer on your next patch to catch your reviewers' attention. Thanks!
Assignee: ehung → bruhuang
Flags: needinfo?(ehung)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8351550 -
Flags: review?(ehung)
|
|
||
Comment 16•11 years ago
|
||
Comment on attachment 8351550 [details]
Add Bluetooth address to settings.
I think the patch is okay to me because it follows the same logic of Mac Address. However, we will refactor some of these code because we want sub-panels are independent, i.e. every panel should be self-contained to update its information, never reply on root panel (connectivity.js or settings.js in this patch) to update a sub-panel's entries.
Anyway, I think we can land this patch and leave refactor work as a follow-up.
@Arthur, what do you think?
Attachment #8351550 -
Flags: review?(ehung) → review+
Flags: needinfo?(arthur.chen)
|
||
Comment 17•11 years ago
|
||
Let's land the patch. We will refactor it along with the mac address part.
Flags: needinfo?(arthur.chen)
|
|
||
Comment 18•11 years ago
|
||
merged into gaia-master: https://github.com/mozilla-b2g/gaia/commit/9cfc5da54cc69a8d700f1e5267759878be88fd69
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•