Closed
Bug 834146
Opened 12 years ago
Closed 12 years ago
Media Element doesn't initialize visibility state into AudioChannelAgent when starting to play.
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(blocking-b2g:tef+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18 verified, b2g18-v1.0.0 fixed, b2g18-v1.0.1 verified)
People
(Reporter: mchen, Assigned: mchen)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mchen
:
review+
|
Details | Diff | Splinter Review |
Open bug from https://bugzilla.mozilla.org/show_bug.cgi?id=821627#c7
## Repro :
1. Play a song in music app
2. launch video
3. select a video (not play yet)
4. wait until the song from music app switches to the next song
5. play a video
## Expected :
1. music app stops, video plays sound
## Actual :
1. music app continues to play, video plays the sound as well.
Note:
I believe it has to do when the music switches to the next song that it over rides, because it kills the thread for the song and opens a new thread.
Assignee | ||
Comment 1•12 years ago
|
||
Root cause:
If the music player try to play the next song in the background, a new AudioChannelAgent will be created but not set visibility well actively in that time. And the initial state of visibility in AudioChannelAgent is visible so in this case it will use visible state to register into AudioChannelService.
Solution:
When creating AudioChannelAgent, try to set up initial visibility state.
Attachment #705739 -
Flags: review?(kinetik)
Comment 2•12 years ago
|
||
This blocks a tef+ blocker so needs to be tef+ itself.
blocking-b2g: --- → tef+
Updated•12 years ago
|
Attachment #705739 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 3•12 years ago
|
||
All green in try server.
https://tbpl.mozilla.org/?tree=Try&rev=b21c3fc83c9c.
Assignee | ||
Comment 4•12 years ago
|
||
Add reviewer and a=tef+ in commit message.
Attachment #705739 -
Attachment is obsolete: true
Attachment #706228 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 5•12 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → B2G C4 (2jan on)
Comment 6•12 years ago
|
||
status-b2g18:
--- → fixed
status-firefox18:
--- → wontfix
status-firefox19:
--- → affected
status-firefox20:
--- → affected
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Updated•12 years ago
|
status-b2g18-v1.0.0:
--- → fixed
status-firefox18:
wontfix → ---
Updated•12 years ago
|
status-b2g18-v1.0.1:
--- → fixed
Comment 8•12 years ago
|
||
Unagi Build ID: 20130313070202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/e74dafa6b2d9
Gaia: b34e726147f8e671ad8c538b50900ccfbffcb084
Kernel: Dec 5th
Unable to get the bug to repro on the build above. Playing a song in Music with other songs in Queue then trying to play a video at the song switch does not seem to cause music to play over the top of the video. I've tried multiple timing scenarios and could not repro. Marking as Verified fixed.
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
Updated•12 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•