Closed Bug 834191 Opened 12 years ago Closed 12 years ago

[Captive Portal] Turn on wifi button on quick settings when the remembered wifi is in captive portal mode

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:shira+, b2g18 fixed, b2g18-v1.0.1 fixed)

VERIFIED FIXED
blocking-b2g shira+
Tracking Status
b2g18 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: alive, Assigned: alive)

References

Details

(Whiteboard: QARegressExclude)

Attachments

(1 file)

STR: 1. Go to settings app 2. Turn on wifi 3. Click a wifi w/ captive portal 4. don't login 5. goto utility-tray >> quick settings 6. Turn on wifi Expected: Open browser app because the wifi in step 3 is already remembered. Actual: Settings app is opened. User doesn't what to do now.
blocking-b2g: shira? → shira+
Depends on: 805289
805289 changes the behavior of quick settings of wifi. It would have 2s timer to check if the wifi is connected. If after 2s it's still not connected, settings app would be opened. Proposed change to this bug: use notification anyway before the user actually click the wifi ap in settings app. I guess I don't need to do any code change but still need to test.
need info from UX
Flags: needinfo?(kyee)
Flags: needinfo?(jcarpenter)
Flags: needinfo?(aganesan)
Summary: [Captive Portal] Turn on wifi button on quick settings should go to browser app instead of settings app if the remembered wifi is in captive portal mode → [Captive Portal] Turn on wifi button on quick settings when the remembered wifi is in captive portal mode
According to bug 805289 the intended behavior is to show a selection dialogue of the networks available to connect to. The user shouldn't be directed to the settings app. > Proposed change to this bug: use notification anyway before the user > actually click the wifi ap in settings app. I guess I don't need to do any > code change but still need to test. I don't think I am understanding what you mean by this suggestion. Do you mean have open Wifi networks show up as a notification in the utility tray?
Flags: needinfo?(kyee)
Oops. I missed out the captive portal part. If the user has already connected to this network previously, toggling wifi on should connect the user to the network and the captive portal login screen should be presented. In the case that there is no known network to connect to, the user is presented with a list of wifi networks available. Selecting a open network with captive portal support should then present a login screen.
Want to make sure everyone knows that Shira is targeting 2/15 code freeze. Shira+ bugs needs more attention for unassigned, needinfo?, review? Full regression test is planned on 2/6. Need to have shira+ bugs landed by the end of 2/5 to be covered in full regression testing. Thanks
Flags: needinfo?(jcarpenter) → needinfo?(alive)
Patch v1: Open browser via quick settings after connecting to known captive portal AP.
Attachment #709644 - Flags: review?(timdream)
Flags: needinfo?(alive)
This is very ideally because we have API latency. Sometimes the WiFi API won't give feedback quickly when you enable it, patch for bug 805289 have a 2sec timer to detect the WiFi connecting status. If WiFi doesn't become connected in 2 sec, it opens the settings app WiFi page. However the WifiManager in backend may connected to the AP after the settings app is opened. In this (edge) case, the user would see the settings app is opened at first and a notification would be poped up. In normal case if it connects to the captive portal AP within 2 sec after clicking quick settings, the browser app would be opened to the user to the login page. (In reply to Casey Yee [:cyee] from comment #4) > Oops. I missed out the captive portal part. > > If the user has already connected to this network previously, toggling wifi > on should connect the user to the network and the captive portal login > screen should be presented. > > In the case that there is no known network to connect to, the user is > presented with a list of wifi networks available. Selecting a open network > with captive portal support should then present a login screen.
(In reply to Alive Kuo [:alive] from comment #7) > This is very ideally because we have API latency. > Sometimes the WiFi API won't give feedback quickly when you enable it, > patch for bug 805289 have a 2sec timer to detect the WiFi connecting status. > If WiFi doesn't become connected in 2 sec, it opens the settings app WiFi > page. > However the WifiManager in backend may connected to the AP after the > settings app is opened. > In this (edge) case, the user would see the settings app is opened at first > and a notification would be poped up. > > In normal case if it connects to the captive portal AP within 2 sec after > clicking quick settings, the browser app would be opened to the user to the > login page. > As per our conversation on IRC. This is certainly not ideal but something we can live with for now.
Comment on attachment 709644 [details] https://github.com/mozilla-b2g/gaia/pull/7944 r=me with one small comment. Additionally, could you add a new line to the end of the file to all new files so that diff won't complain about it? Thanks.
Attachment #709644 - Flags: review?(timdream) → review+
Flags: needinfo?(aganesan)
Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1
Whiteboard: QARegressExclude
Unagi Gaia: 819afb8758de9fbf87eca837e328818de93307ec Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/96f559f949bb BuildID 20130402230203 Version 18.0 Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: