Closed Bug 834219 Opened 12 years ago Closed 12 years ago

[Captive Portal] Squash the notifications in the same captive portal

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:shira+, b2g18 fixed, b2g18-v1.0.1 fixed)

VERIFIED FIXED
blocking-b2g shira+
Tracking Status
b2g18 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: alive, Assigned: alive)

References

Details

(Whiteboard: [triaged: 1/29] QARegressExclude)

Attachments

(2 files)

Attached image snapshot of many notifications (deleted) —
See snapshot. I found this when I put my device on the desk and left for a while. Theres notifications are about the same wifi, which should stack there to an amazing amount if I don't notice them. (100+ notifications expected....) This is very bad. schien, we should talk and figure out if we could limit the numbers of mozChromeEvent from gecko or we should block the notifications from gaia.
Assignee: nobody → alive
Summary: [Captive Portal] Squash the notification in the same captive portal → [Captive Portal] Squash the notifications in the same captive portal
QA Contact: fyen
blocking-b2g: shira? → shira+
QA Contact: fyen
Flags: needinfo?(schien)
Looks like the wifi is disconnected and connected for every few minutes. :( There should be at most 1 notification for captive portal login. Gecko will send |captive-portal-login-abort| event to gaia for removing notification. I see code already land on shira branch and I'm not sure if these code works correctly on your test environment. ( https://github.com/mozilla-b2g/gaia/blob/shira/apps/system/js/captive_portal.js#L41 )
Flags: needinfo?(schien)
triage: qawanted to confirm on the pvtbuilds
Keywords: qawanted
Whiteboard: [triaged: 1/29]
820288, 820279 is landed on v1-train so need QA's love from tomorrow on ;)
Want to make sure everyone knows that Shira is targeting 2/15 code freeze. Shira+ bugs needs more attention for unassigned, needinfo?, review? Full regression test is planned on 2/6. Need to have shira+ bugs landed by the end of 2/5 to be covered in full regression testing. Thanks
I don't see this these days..make shira? and if so WFM.
blocking-b2g: shira+ → shira?
shira-, please renom if reproducible.
blocking-b2g: shira? → ---
This happens again when I brought the device with me back on holiday. And I find reproducible steps: 1. Turn on wifi 2. Choose an AP w/ captive portal 3. Press power button 4. Press Again 5. On lockscreen, long press power button. 6. Turn on airplane mode 7. Long press power button and turn off airplane mode. You will see 2 notifications are there on lockscreen. Turn on/off airplane mode is simulating the condition that AP is connected and disconnected. Confirmed this is a gaia bug. Patch coming.
blocking-b2g: --- → shira?
Patch v1: Also remove notification node on lockscreen if possible.
Attachment #715015 - Flags: review?(timdream)
blocking-b2g: shira? → shira+
Alive, this only removes the notifications. Is there a bug that you created as follow up to see why the wifi is disconnecting and reconnecting? I seeing what :schien noted in comment 1.
(In reply to Naoki Hirata :nhirata from comment #12) > Alive, this only removes the notifications. Is there a bug that you created > as follow up to see why the wifi is disconnecting and reconnecting? I > seeing what :schien noted in comment 1. You could create a new bug for that :)
Thanks Alive. Created bug 843786. Removing qawanted as this is already in the 1.0.1 build.
Keywords: qawanted
per comment 10&11, this is fixed on v1-train and v1.0.1
Whiteboard: [triaged: 1/29] → [triaged: 1/29] QARegressExclude
Unagi Gaia: 819afb8758de9fbf87eca837e328818de93307ec Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/96f559f949bb BuildID 20130402230203 Version 18.0 Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: