Closed
Bug 834869
Opened 12 years ago
Closed 12 years ago
AudioBuffer's Unlink method should drop js objects
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
I think AudioBuffer's Unlink method is wrong, since it doesn't drop JS objects, like other Unlink methods.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
You also should put |mChannels.Clear()| in there before it or you'll angry up the use-after-unlink detector.
|
|
Assignee | |
Comment 3•12 years ago
|
||
Thanks for volunteering to review this. :P
Attachment #706566 -
Attachment is obsolete: true
Attachment #706566 -
Flags: review?(bzbarsky)
Attachment #706620 -
Flags: review?(continuation)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 706620 [details] [diff] [review]
Patch (v2)
Review of attachment 706620 [details] [diff] [review]:
-----------------------------------------------------------------
Happy to help!
Attachment #706620 -
Flags: review?(continuation) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
roc, this will affect your patches. CCing you to keep you in the loop
|
|
Assignee | |
Comment 6•12 years ago
|
||
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
|
Assignee | |
Comment 8•11 years ago
|
||
Mass moving Web Audio bugs to the Web Audio component. Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in
before you can comment on or make changes to this bug.
Description
•