The Gaia music app currently creates a thumbnail album art for every song even though all the songs on the same album typically have identical art. It should cache thumbnails based on the album name, artist name, and cover art size, and reuse the cached thumbnail when possible.

The attachment is a github pull request that I didn't finish in time to land as part of the tef+ blocker bug 814178. So I'm attaching it here. For my test set of 270 iTunes m4a files, it improves parsing speed by about 30%. This patch got r+ by jlal over in bug 814178, so I've marked that r+ here. I'm going to land this on gaia master now and request approval to uplift it somewhere.

Whiteboard oops...

Comment on attachment 706614 [details] link to patch on github NOTE: If blocking-basecamp+ is set, just land it for now. [Approval Request Comment] Bug caused by (feature/regressing bug #): not a regression, just a recently discovered performance issue. User impact if declined: new music will take ~30% longer to scan. Testing completed: yes, tested the music app Risk to taking this patch (and alternatives if risky): if I've done it wrong, the wrong album art could be displayed for some songs. But that doesn't seem to be happening in my testing.

Merged into gaia master https://github.com/mozilla-b2g/gaia/commit/3ca7349e171f67e784cbff18621e642e6e0a7770 This is a substantial performance improvement for the music app and I'd love to get it uplifted.

Merged into v1.0.0: https://github.com/mozilla-b2g/gaia/commit/400f2d2f187f9f1447155fee3c865110471002ae

marking as fixed on branch

Comment on attachment 706614 [details] link to patch on github Clearing the approval flag since this is tef+ and can be uplifted when ready without approval.

Comment 5 is not correct, patch wasn't uplifted to v1.0.0 or v1-train. This will be included in an uplift in a little while.

Correction to Comment 8, this was on v1.0.0 as https://github.com/mozilla-b2g/gaia/commit/ea30ad42f0edf12e02ecdb41ee1d80eca350b78c Uplifted to v1-train: https://github.com/mozilla-b2g/gaia/commit/678e42ba43d3d5dd286aa8b32c90b1906dfe5292

Issue does not repro anymore. Verified on Unagi Build ID: 201302014070203 Kernel: Dec 5 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/a9e4f8912607 Gaia: 21ba59d933c66024cb351c2379315301d5352e0c