Closed
Bug 835143
Opened 12 years ago
Closed 11 years ago
WebSTK: Implement StkCommandEvent using event generator
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: vicamo, Assigned: edgar)
References
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
smaug
:
review+
vicamo
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → vyang
|
|
Reporter | |
Comment 1•12 years ago
|
||
> BaseException: JS::Value not supported in simple events!
Hi Olli, do you know what happened? Seems something has to be fixed first, or we should create an interface for each STK event. :(
Attachment #706883 -
Flags: feedback?(bugs)
|
||
Comment 2•12 years ago
|
||
jsvals aren't indeed supported. One could use nsIVariant (XPCVariant).
http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/nsIXPConnect.idl#422
|
|
||
Updated•12 years ago
|
Attachment #706883 -
Flags: feedback?(bugs)
|
|
Reporter | |
Comment 3•11 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #2)
> jsvals aren't indeed supported. One could use nsIVariant (XPCVariant).
> http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/idl/nsIXPConnect.
> idl#422
nsIWritableVariant has only |setAsISupports()|. Does that mean I have to create an interface for at least MozStkCommand? And I'll also have to make it a DOM interface, one that written by WebIDL? Am I right? Thank you.
Flags: needinfo?(bugs)
|
Assignee | |
Comment 8•11 years ago
|
||
Use webidl event generator
Attachment #777787 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 9•11 years ago
|
||
Comment on attachment 826780 [details] [diff] [review]
Patch, v3
Review of attachment 826780 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/webidl/moz.build
@@ +568,5 @@
> 'GamepadButtonEvent.webidl',
> 'GamepadEvent.webidl',
> ]
>
> +if CONFIG['MOZ_B2G_RIL']:
Don't. For interfaces converted to WebIDL, we use Pref="dom.foo.enabled" as you've already had in | MozStkCommandEvent.webidl|.
|
|
Assignee | |
Comment 10•11 years ago
|
||
1). Address comment #9.
2). Correct test_all_synthetic_events.html.
Attachment #826780 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Attachment #827314 -
Flags: feedback?(vyang)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #827314 -
Flags: feedback?(vyang) → feedback+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #827314 -
Flags: review?(bugs)
|
|
||
Updated•11 years ago
|
Attachment #827314 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 11•11 years ago
|
||
Thanks for the review and feedback.
try server: https://tbpl.mozilla.org/?tree=Try&rev=25a85c90931f
|
|
Assignee | |
Comment 12•11 years ago
|
||
|
||
Comment 13•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in
before you can comment on or make changes to this bug.
Description
•