Closed Bug 83570 Opened 23 years ago Closed 23 years ago

XUL popups can appear below dock

Categories

(Core :: XUL, defect, P2)

PowerPC
macOS
defect

Tracking

()

VERIFIED FIXED
mozilla0.9.5

People

(Reporter: mikepinkerton, Assigned: mikepinkerton)

Details

(Whiteboard: OSX, PDT+)

Attachments

(1 file, 1 obsolete file)

on osx, popups can be positioned so that part of them are below the dock. this makes them impossible to access. the solution is to use ::GetAvailableWindowPositioningBounds() from CarbonLib 1.3 in nsScreenMac instead of simply checking the GDHandle. Luckily, the bounds we get back are a rect since gecko can't handle regions in any of the window positioning code.
Status: NEW → ASSIGNED
Keywords: nsmac1
Whiteboard: OSX
Target Milestone: --- → mozilla0.9.3
Target Milestone: mozilla0.9.3 → mozilla0.9.4
This is also a problem for tooltips for the status bar buttons. Should that be a separate bug or can it be thrown in with this?
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Priority: -- → P2
This is one of those particularly annoying interface bugs.
nominating for branch, this should be an easy kill after looking at the code.
Keywords: nsbranch+
Attached patch use OS calls to remove dock/menubar (obsolete) (deleted) — Splinter Review
patch attached that uses ::GetAvailableWindowPositioningBounds() to sub out the dock and the menubar. removes our code that does this for carbon builds only. needing r/sr. this is a safe patch, and big bang for the buck.
r=sdagley
Attachment #50565 - Attachment is obsolete: true
Comment on attachment 50567 [details] [diff] [review] same patch, more lines of context sr=sfraser
Attachment #50567 - Flags: superreview+
Attachment #50567 - Flags: review+
per PDT email thread, mark PDT+. Does this also affect OS besides OS X?
Whiteboard: OSX → OSX, PDT+
landed on branch, waiting for trunk to open.
on trunk now
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
verified fixed 9.4 branch for xul popups, including tooltips, not extending below/behind the dock
Status: RESOLVED → VERIFIED
Keywords: vtrunk
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: