Closed
Bug 835758
Opened 12 years ago
Closed 11 years ago
Lots of keypad duplicated code between apps/communication/dialer and apps/system/emergency-call
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Firefox OS Graveyard
Gaia::Dialer
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: sergi, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20130122 Firefox/21.0
Build ID: 20130122030956
Actual results:
There is a lot of code duplicated in the apps/communication/dialer/js/keypad.js and apps/system/emergency-call/js/keypad.js. That means that every time that there is a non-specific change to the keypad, both files have to be changed, making it easy to forget and to introduce bugs.
Expected results:
Both keypads should share a base implementation and add their particular behaviors to that implementation.
|
Reporter | |
Comment 1•12 years ago
|
||
I made a patch that fixes that. The Pull Request is at https://github.com/mozilla-b2g/gaia/pull/7843.
|
|
Reporter | |
Comment 2•12 years ago
|
||
|
|
Reporter | |
Updated•11 years ago
|
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
|
Assignee | |
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
|
||
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•