Closed
Bug 835832
Opened 12 years ago
Closed 12 years ago
BaselineCompiler: Optimized stub for string getelem
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #707640 -
Flags: review?(jdemooij)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 707640 [details] [diff] [review]
v1
Review of attachment 707640 [details] [diff] [review]:
-----------------------------------------------------------------
Nice, thanks!
::: js/src/ion/BaselineIC.cpp
@@ +1625,5 @@
> // But for now we just bail.
> return true;
> }
>
> + if (lhs.isString() && rhs.isInt32() && res.isString()) {
Nit && !stub->hasStub(ICStub::GetElem_String)
To avoid adding the same stub multiple times.
Attachment #707640 -
Flags: review?(jdemooij) → review+
|
Assignee | |
Updated•12 years ago
|
Assignee: general → evilpies
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•