Closed
Bug 835915
Opened 12 years ago
Closed 12 years ago
JSCustomObjectBuilder.cpp:211:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Build warning:
{
16:54.79 /scratch/work/builds/mozilla-inbound/mozilla/tools/profiler/JSCustomObjectBuilder.cpp: In function 'std::ostream& operator<<(std::ostream&, JSCustomArray*)':
16:54.79 Warning: -Wsign-compare in /scratch/work/builds/mozilla-inbound/mozilla/tools/profiler/JSCustomObjectBuilder.cpp: comparison between signed and unsigned integer expressions
16:54.79 /scratch/work/builds/mozilla-inbound/mozilla/tools/profiler/JSCustomObjectBuilder.cpp:211:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}
Trivial fix; just need to change loop iterator variable to be unsigned instead of signed. (since it's iterating up to a nsTArray's Length() which is unsigned)
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Updated•12 years ago
|
Attachment #707717 -
Flags: review?(bgirard) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Flags: in-testsuite-
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•