Closed Bug 836045 Opened 12 years ago Closed 12 years ago

Update Webapps code to use the new deviceStorage stat() support

Categories

(Core Graveyard :: DOM: Apps, defect)

Product:
Core Graveyard
Component:
DOM: Apps
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:tef+, firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 fixed, b2g18-v1.0.1 fixed)

Status:
VERIFIED FIXED
Milestone:
mozilla21
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
firefox19 --- wontfix
firefox20 --- wontfix
firefox21 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: tchung, Assigned: fabrice)

References

Details

(Keywords: regression, smoketest)

Attachments

(1 file)

patch
(deleted), patch
djf
: review+
dougt
: review+
Details | Diff | Splinter Review
Trying to update the HERE maps webapp via OTA. fails to update. Logcat: 01-29 14:38:40.381: E/GeckoConsole(108): [JavaScript Error: "DOMApplicationRegistry: Could not parse JSON: /data/local/webapps/m.here.com/staged-update.webapp TypeError: deviceStorage.stat is not a function 01-29 14:38:40.381: E/GeckoConsole(108): @resource://gre/modules/Webapps.jsm:2242 01-29 14:38:40.381: E/GeckoConsole(108): startDownload/<@resource://gre/modules/Webapps.jsm:978 01-29 14:38:40.381: E/GeckoConsole(108): @resource://gre/modules/Webapps.jsm:640 01-29 14:38:40.381: E/GeckoConsole(108): NetUtil_asyncOpen/<.onStopRequest@resource://gre/modules/NetUtil.jsm:140 01-29 14:38:40.381: E/GeckoConsole(108): " {file: "resource://gre/modules/Webapps.jsm" line: 643}] Repro: 1) install nightly unagi build: Gecko http://hg.mozilla.org/releases/mozilla-b2g18/rev/945b0ed70929 Gaia 0dcff9e1ff93d5c035f4a7b1bd28dd0e53792ef0 BuildID 20130129094039 Version 18.0 2) check for updates, and find one available for the NOkia HERE maps application 3) apply the update via notification dropdown 4) Verify failed to apply update Expected: - devicestorage works, update success Actual; - 3rd party update fails
Summary: 3rd party update fail: 01-29 14:38:40.381: E/GeckoConsole(108): [JavaScript Error: "DOMApplicationRegistry: Could not parse JSON: /data/local/webapps/m.here.com/staged-update.webapp TypeError: deviceStorage.stat is not a function 01-29 14:38:40.381: E/Gec → 3rd party update fail: [JavaScript Error: "DOMApplicationRegistry: Could not parse JSON: /data/local/webapps/m.here.com/staged-update.webapp TypeError: deviceStorage.stat is not a function 01-29 14:38:40.381: E/Gec
Summary: 3rd party update fail: [JavaScript Error: "DOMApplicationRegistry: Could not parse JSON: /data/local/webapps/m.here.com/staged-update.webapp TypeError: deviceStorage.stat is not a function 01-29 14:38:40.381: E/Gec → 3rd party update fail: [JavaScript Error: "DOMApplicationRegistry: Could not parse JSON: /data/local/webapps/m.here.com/staged-update.webapp TypeError: deviceStorage.stat is not a function
Summary: 3rd party update fail: [JavaScript Error: "DOMApplicationRegistry: Could not parse JSON: /data/local/webapps/m.here.com/staged-update.webapp TypeError: deviceStorage.stat is not a function → Update Webapps code to use the new deviceStorage stat() support
Attached patch patch (deleted) — — Splinter Review
Bah.
Assignee: nobody → fabrice
Attachment #707835 - Flags: review?(doug.turner)
Attachment #707835 - Flags: review?(dflanagan)
Keywords: smoketest
Comment on attachment 707835 [details] [diff] [review] patch Review of attachment 707835 [details] [diff] [review]: ----------------------------------------------------------------- looks good to me.
Attachment #707835 - Flags: review?(dflanagan) → review+
Component: General → DOM: Apps
Product: Boot2Gecko → Core
Version: unspecified → Trunk
Keywords: regression
Attachment #707835 - Flags: review?(doug.turner) → review+
Thanks for the quick turnaround!
Oh, this is most definitely a TEF+ blocker. Package installation don't work at all without this change.
https://hg.mozilla.org/mozilla-central/rev/4f7371e936e0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Keywords: verifyme
QA Contact: jsmith
blocking-b2g: tef? → tef+
Smoke Test Regression Build 20130130070201 gaia: f7f5a0cd17e3d04308cc5850b254947e127122b9 gecko:066b9d7cf30884a001db22bde3ae939c02718062 Dec 5th kernel ,pmem_adsp_size=13631488 Unable to download privileged app , receive error message. Repro frequency : 5/5 times on 2/2 devices
No longer blocks: 836639
Verified on 1/31 - sanity tests look good, although by doing this testing we've caught two new bugs (bug 836909 and bug 836859).
Status: RESOLVED → VERIFIED
Keywords: verifyme
Need a testcase, no? /be
Keywords: testcase-wanted
(In reply to Brendan Eich [:brendan] from comment #15) > Need a testcase, no? Yes, as soon as the new tests infra lands (bug 826058) we'll add a lot more to cover this kind of regressions.
(In reply to Fabrice Desré [:fabrice] from comment #16) > (In reply to Brendan Eich [:brendan] from comment #15) > > Need a testcase, no? > > Yes, as soon as the new tests infra lands (bug 826058) we'll add a lot more > to cover this kind of regressions. Agreed. bug 821589 is already tracking the work that will catch a regression such as this one. We probably work on that after bug 826058 lands.
Keywords: testcase-wanted
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: