Closed Bug 83616 Opened 23 years ago Closed 23 years ago

:not(.foo) broken

Categories

(Core :: CSS Parsing and Computation, defect, P2)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.2

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Keywords: css3, testcase, Whiteboard: [Hixie-P4])

Attachments

(3 files)

testcase
(deleted), text/html
Details
patch
(deleted), patch
Details | Diff | Splinter Review
fix a few more things while I'm here (needs more testing)
(deleted), patch
Details | Diff | Splinter Review
:not(.foo) (i.e., :not() with a class selector inside) is broken. The problem can be fixed by changing 2 adjacent lines in nsCSSStyleSheet.cpp. It's caused by using the "local" boolean in the wrong place. Testcase to be attached.
Attached file testcase (deleted) —
Priority: -- → P3
Target Milestone: --- → mozilla1.0
Attached patch patch (deleted) — — Splinter Review
taking
Assignee: glazman → dbaron
Status: NEW → ASSIGNED
Priority: P3 → P2
Target Milestone: mozilla1.0 → mozilla0.9.2
Looks fine. [s]r=attinasi - thanks David.
per discussion on IRC, r=hixie
OK, I'm happy with the correctness of the changes in the above patch (did a bit of local testing with a single element and single selector that I kept changing), and they do fix the bugs I expected them to fix. I think we should get the WG to clarify the meaning of |= though, since I don't think Daniel's interpretation is backed by the spec.
The |= stuff is covered by Bug 75872.
Blocks: 75872
sr=attinasi on the latest patch.
a= asa@mozilla.org for checkin to the trunk. (on behalf of drivers)
Blocks: 83989
Fix checked in 2001-06-19 15:46 PDT.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: