Issue with Dragging: Dragging in contact application is very slow. The Frames per second is very low when user drags on the contact loaded in contact list. Issue with Scrolling: Scrolling in contact application is very slow 1. When the application is launched and then try to scroll. 2. Revisit contact application from different application. Please note that the above items are tested with 1000 contacts inserted using UI test application.

Alberto, we should use oncontactchange from bug 750768 to avoid reloadings.

(In reply to leo.bugzilla.gaia from comment #0) > Issue with Dragging: > Dragging in contact application is very slow. The Frames per second is very > low when user drags on the contact loaded in contact list. > > Issue with Scrolling: > Scrolling in contact application is very slow > 1. When the application is launched and then try to scroll. > 2. Revisit contact application from different application. > > Please note that the above items are tested with 1000 contacts inserted > using UI test application. Hi leo. Has this test have done with the patch for Bug 835742 or with master? That patch should fix the 2nd issue, as we are not repainting by chunks when revisiting the app, so the scrolling should be fine. Could you please give it a try, please? Regarding the dragging issue, I don't fully understand what you mean by dragging a contact. I guess both issues are only when loading the app. As soon as the 1000 contacts are loaded, everything works fine?

Hi Gregor, How can I listen to changes made from another app? As far as I know, I can't receive those events if the contacts app is in background. Taking that in account, that event only would be useful making changes from the same Contacts app, and we already avoid reloading when changing something from the Contacts app. May be I'm wrong with the fact that I can't receive that event in background. In that case, that would improve a lot. Anyway, as per my previous comment, I think the main issue is when loading contacts first time. When revisiting the app should be fixed by the other patch. Thanks! (In reply to Gregor Wagner [:gwagner] from comment #1) > Alberto, we should use oncontactchange from bug 750768 to avoid reloadings.

(In reply to Alberto Pastor from comment #3) > Hi Gregor, > > How can I listen to changes made from another app? As far as I know, I can't > receive those events if the contacts app is in background. Taking that in > account, that event only would be useful making changes from the same > Contacts app, and we already avoid reloading when changing something from > the Contacts app. Oh that isn't very useful but it worked cross-process when I added this feature. It might have regressed when we turned off broadcasting messages via the message manager. Let me fix it :)

(In reply to Gregor Wagner [:gwagner] from comment #4) > (In reply to Alberto Pastor from comment #3) > > Hi Gregor, > > > > How can I listen to changes made from another app? As far as I know, I can't > > receive those events if the contacts app is in background. Taking that in > > account, that event only would be useful making changes from the same > > Contacts app, and we already avoid reloading when changing something from > > the Contacts app. > > Oh that isn't very useful but it worked cross-process when I added this > feature. It might have regressed when we turned off broadcasting messages > via the message manager. > > Let me fix it :) Okay, it's yours :)

@leo, I talked with Ben Francis about the Dragging issue. I'll take a look tomorrow. Regarding scrolling when reloading the app should be already fixed with my patch, but will be even better when oncontactschange get's fixed :) (Thanks gregor!) Scrolling when opening the app for the 1st time while the contacts are being loaded is something I can't find a solution until the cursor based contacts API lands. Happy to hear suggestions there. Thanks! (In reply to Alberto Pastor from comment #2) > (In reply to leo.bugzilla.gaia from comment #0) > > Issue with Dragging: > > Dragging in contact application is very slow. The Frames per second is very > > low when user drags on the contact loaded in contact list. > > > > > Issue with Scrolling: > > Scrolling in contact application is very slow > > 1. When the application is launched and then try to scroll. > > 2. Revisit contact application from different application. > > > > Please note that the above items are tested with 1000 contacts inserted > > using UI test application. > > Hi leo. Has this test have done with the patch for Bug 835742 or with > master? That patch should fix the 2nd issue, as we are not repainting by > chunks when revisiting the app, so the scrolling should be fine. Could you > please give it a try, please? > > Regarding the dragging issue, I don't fully understand what you mean by > dragging a contact. > > I guess both issues are only when loading the app. As soon as the 1000 > contacts are loaded, everything works fine?

Marking status-b2g18 and status-b2g18-v1.0.0 as affected, please update the status to fixed once this is verified landed on v1-train/mozilla-b2g18 and v1.0.0/mozilla-b2g18_v_1_0_0

Hi, I've tested this with patch in comment 2, and the second issue as Alberto comments disappears. What I'm not totally sure is what's the use case for 1. Are we talking about the contact list it self while dragging or the contact detail? Leo can you provide more information? Thanks!

(In reply to Francisco Jordano [:arcturus] from comment #8) > Hi, > > I've tested this with patch in comment 2, and the second issue as Alberto > comments disappears. > > What I'm not totally sure is what's the use case for 1. > > Are we talking about the contact list it self while dragging or the contact > detail? > > Leo can you provide more information? Thanks! I think it's basically the same problem. When starting the contacts app the first time (1) or when switching to the contacts app (2), the contact list scrolling is very slow for a few seconds if you have a test case with 1000 contacts.

(In reply to Gregor Wagner [:gwagner] from comment #9) > (In reply to Francisco Jordano [:arcturus] from comment #8) > > Hi, > > > > I've tested this with patch in comment 2, and the second issue as Alberto > > comments disappears. > > > > What I'm not totally sure is what's the use case for 1. > > > > Are we talking about the contact list it self while dragging or the contact > > detail? > > > > Leo can you provide more information? Thanks! > > I think it's basically the same problem. When starting the contacts app the > first time (1) or when switching to the contacts app (2), the contact list > scrolling is very slow for a few seconds if you have a test case with 1000 > contacts. Hi the scrolling meanwhile the list is loading or switching to the contacts app from another app is the same problem and Alberto is already addressing it. I would like to focus on the problem: Issue with Dragging: Dragging in contact application is very slow. The Frames per second is very low when user drags on the contact loaded in contact list. We don't see this problem once the list is loaded, so we would like Leo to provide more feedback or STR :) Thanks!

Francisco: Will you please tell me what exact information you need? As I understand Alberto has already discussed with Ben on dragging issue. Scrolling is basically a flick where as dragging is touch down and move up and down without lifting finger.

Comment on attachment 711370 [details] WIP - No repaitingin when Contacts app coming back from background using onContactChange Jose Manuel, since this change also modifies contacts could you take a look? Thanks.

Comment on attachment 711370 [details] WIP - No repaitingin when Contacts app coming back from background using onContactChange Monday and Tuesday I'm gonna be on a meeting and not very available to review this, as this is tef+ I'm asking Cristian to review, as he also knows Contacts code and can check for regressions in FB refreshes.

sorry my previous comments on previous pull request? :)

Sorry Cristian, didn't realise, will check them :)

I've moved all comments to the new pr, thanks Fran!

Hi guys, new version of the PR updated with comments :) Thanks!

Comment on attachment 712484 [details] Pointer to GitHub PR 8045 Please Cantera take a look in your device. For me is OK although more eyes better

Hi all, Francisco, thanks for the hard work! I posted in GH some problems with the patch. please let us know if you need help in fixing them best

Jose Manuel can you r? again? There is a new version hopefully fixing the errors you comment in Github

Landed https://github.com/mozilla-b2g/gaia/pull/8045#discussion_r3010284

I mean, landed here: https://github.com/mozilla-b2g/gaia/commit/3859bf498196d2c7c640e38b2f9a76061d6a245b

Looks like this patch needs a manual rebase to land cleanly on v1.0.1.

Alberto is rebasing today.

(In reply to Michael Vines [:m1] [:evilmachines] from comment #25) > Looks like this patch needs a manual rebase to land cleanly on v1.0.1. (In reply to Dietrich Ayala (:dietrich) from comment #26) > Alberto is rebasing today. Is Alberto also going to be able to land it on v1-train?

Alberto was not able to get to it. I've pinged people in pst about getting this and the other Contacts perf bugs onto the right branches by EOD.

(In reply to Dietrich Ayala (:dietrich) from comment #26) > Alberto is rebasing today. Today is a relative concept, but yes, I finally got time to make it! https://github.com/albertopq/gaia/tree/merge-836170 Regards,

v1-train: c48e9ebb04cf089f7db258509b8da76053fdfca4 v1.0.1: 065f2bd690f0cf92b1eb42a4125ee6323e5c6180

We have tested the dragging and flicking performance on leo device using the high speed camera. The result of the flicking is 54fps. But the result of the dragging is 40fps. We need to improve the performace of dragging over 50fps. So we reopen this issue.

Dup Bug 842217 ?

This bug is already landed code, let's leave it TEF+ and closed, and use bug 842217 for further improvements.