Closed
Bug 836294
Opened 12 years ago
Closed 12 years ago
nsIMediaDevices (MediaEngineAudioSource and MediaEngineVideoSource) leak after using gum with UI
Categories
(Core :: WebRTC: Audio/Video, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: jesup, Assigned: jesup)
References
Details
(Keywords: memory-leak, Whiteboard: [getUserMedia][blocking-gum+][MemShrink][qa-])
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
When using mozGetUserMedia, if the UI is enabled we leak a copy of every media source device and an nsTArray (and perhaps some related objects). We don't see it in the mochitests as they suppress the permission UI.
Caused by copying an allocated nsTArray<nsCOMPtr <...> >, which is then dropped on the floor.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #708131 -
Flags: review?(bzbarsky)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 708131 [details] [diff] [review]
Don't drop array of media devices on the floor
r=me
Attachment #708131 -
Flags: review?(bzbarsky) → review+
|
||
Updated•12 years ago
|
Whiteboard: [getUserMedia][blocking-gum+]
|
|
Assignee | |
Comment 3•12 years ago
|
||
Target Milestone: --- → mozilla21
|
||
Updated•12 years ago
|
Whiteboard: [getUserMedia][blocking-gum+] → [getUserMedia][blocking-gum+][MemShrink]
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
Whiteboard: [getUserMedia][blocking-gum+][MemShrink] → [getUserMedia][blocking-gum+][MemShrink][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•