Closed Bug 836419 Opened 12 years ago Closed 12 years ago

test-events.test:emitLoop claims an error in tinderbox output mode

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file)

In verbose output: info: addon-sdk: executing 'test-events.test:emitLoop' error: addon-sdk: An exception occurred. undefined: undefined undefined undefined Traceback (most recent call last): info: addon-sdk: pass: emit didn't looped 1 of 1 tests passed. In parseable output: TEST-START | test-events.test:emitLoop TEST-UNEXPECTED-FAIL | An exception occurred. Traceback (most recent call last): Exception in error event listener Error: error TEST-PASS | test-events.test:emitLoop | emit didn't looped TEST-END | test-events.test:emitLoop error: addon-sdk: warnings and/or errors were logged. TEST-INFO | [JavaScript Error: "addon-sdk: warnings and/or errors were logged. "] 1 of 2 tests passed.
Assignee: nobody → dtownsend+bugmail
Pointer to Github pull-request
Attachment #708352 - Flags: review?(poirot.alex)
Comment on attachment 708352 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/749 So it means that we aren't using parseable output yet? I'm not ultimately convince that we should ignore exceptions, but it seems reasonable to match the current behavior for now.
Attachment #708352 - Flags: review?(poirot.alex) → review+
(In reply to Alexandre Poirot (:ochameau) from comment #2) > Comment on attachment 708352 [details] > Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/749 > > So it means that we aren't using parseable output yet? We have bugs open with releng to switch to it on tinderbox, hopefully v.soon.
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/ee820e00630614ab11791955e049b45c08b83cfd Bug 836419: Don't log exceptions as a test failure in parseable output to match verbose output. https://github.com/mozilla/addon-sdk/commit/8ba7b689876f88fed33a6364d5b8900b57f1e5f6 Bug 836419: Don't log the expected exception in the emitLoop test. https://github.com/mozilla/addon-sdk/commit/a16bbd5772880b578a939eeb65102bca6560d494 Merge pull request #749 from Mossop/bug836419 Bug 836419: Fix a phantom test failure in parseable output. r=ochameau
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.15
Commits pushed to integration at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/ee820e00630614ab11791955e049b45c08b83cfd Bug 836419: Don't log exceptions as a test failure in parseable output to match verbose output. https://github.com/mozilla/addon-sdk/commit/8ba7b689876f88fed33a6364d5b8900b57f1e5f6 Bug 836419: Don't log the expected exception in the emitLoop test. https://github.com/mozilla/addon-sdk/commit/a16bbd5772880b578a939eeb65102bca6560d494 Merge pull request #749 from Mossop/bug836419
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/a0b24b3b5456ea42c23370f94fbec5ef7ac2fbe5 Merge pull request #749 from Mossop/bug836419 Bug 836419: Fix a phantom test failure in parseable output. r=ochameau(cherry picked from commit a16bbd5772880b578a939eeb65102bca6560d494)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: