Closed
Bug 836524
Opened 12 years ago
Closed 12 years ago
More compartment -> zone renaming
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(6 files)
|
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
Originally I hadn't planned on moving all this stuff to zones, but now I realize I must.
|
Assignee | |
Comment 1•12 years ago
|
||
Change up some assertions.
Attachment #708344 -
Flags: review?(terrence)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Preserving JIT code.
Attachment #708347 -
Flags: review?(terrence)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 708344 [details] [diff] [review]
part 1
Review of attachment 708344 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jscompartment.cpp
@@ +289,5 @@
>
> if (vp->isString()) {
> JSString *str = vp->toString();
>
> /* If the string is already in this compartment, we are done. */
s/compartment/zone/ in the comment.
Attachment #708344 -
Flags: review?(terrence) → review+
|
|
||
Updated•12 years ago
|
Attachment #708347 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
I guess this should have gone in with the previous patches. It's small though.
Attachment #708367 -
Flags: review?(jcoppeard)
|
|
Assignee | |
Comment 7•12 years ago
|
||
Found some more of this junk.
Attachment #708392 -
Flags: review?(jcoppeard)
|
||
Updated•12 years ago
|
Attachment #708345 -
Flags: review?(jcoppeard) → review+
|
|
||
Updated•12 years ago
|
Attachment #708346 -
Flags: review?(jcoppeard) → review+
|
|
||
Updated•12 years ago
|
Attachment #708367 -
Flags: review?(jcoppeard) → review+
|
|
||
Updated•12 years ago
|
Attachment #708392 -
Flags: review?(jcoppeard) → review+
|
|
Assignee | |
Comment 8•12 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/4fec5623f291
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/8794e6654037
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/f4a00ea823fd
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/f61a56d201d6
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/e39eee442314
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/7153a907e6b9
|
||
Comment 9•12 years ago
|
||
|
||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4fec5623f291
https://hg.mozilla.org/mozilla-central/rev/8794e6654037
https://hg.mozilla.org/mozilla-central/rev/f4a00ea823fd
https://hg.mozilla.org/mozilla-central/rev/f61a56d201d6
https://hg.mozilla.org/mozilla-central/rev/e39eee442314
https://hg.mozilla.org/mozilla-central/rev/7153a907e6b9
https://hg.mozilla.org/mozilla-central/rev/67f1ba2a8cb9
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•