Closed
Bug 836547
Opened 12 years ago
Closed 11 years ago
Remove obsolete AITC integration in Webapps.jsm
Categories
(Core Graveyard :: DOM: Apps, defect)
Core Graveyard
DOM: Apps
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: rnewman, Assigned: marco)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
Follow-on from Bug 836395.
Fabrice, please move to the correct component if I messed that up!
|
||
Updated•12 years ago
|
Component: Web Apps → DOM: Apps
Product: Firefox → Core
QA Contact: jsmith
|
|
||
Updated•12 years ago
|
Assignee: nobody → fabrice
|
|
||
Comment 1•11 years ago
|
||
Marco, can you do that before we land bug 909573?
Assignee: fabrice → mcastelluccio
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #796233 -
Flags: review?(fabrice)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Do we want also to completely remove the code under sync/ ?
|
|
||
Comment 4•11 years ago
|
||
(In reply to Marco Castelluccio [:marco] from comment #3)
> Created attachment 796235 [details] [diff] [review]
> remove_aitc
>
> Do we want also to completely remove the code under sync/ ?
Yes, it's obsolete and doesn't support half of what we need.
|
|
Assignee | |
Updated•11 years ago
|
Attachment #796235 -
Flags: review?(fabrice)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 796235 [details] [diff] [review]
remove_aitc
Review of attachment 796235 [details] [diff] [review]:
-----------------------------------------------------------------
Nit: this is not aitc, but an apps sync engine.
Attachment #796235 -
Flags: review?(fabrice) → review+
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 796233 [details] [diff] [review]
remove_aitc_webappsjsm
Review of attachment 796233 [details] [diff] [review]:
-----------------------------------------------------------------
Less code is good news!
Attachment #796233 -
Flags: review?(fabrice) → review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Try run here: https://tbpl.mozilla.org/?tree=Try&rev=f5e44962f81d
Keywords: checkin-needed
|
||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/38dde25713db
https://hg.mozilla.org/integration/fx-team/rev/1cc435abcc52
I used the Try push to figure out what commit message the second patch should have since both attached patches were the same.
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/38dde25713db
https://hg.mozilla.org/mozilla-central/rev/1cc435abcc52
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla26
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•