Closed
Bug 836624
Opened 12 years ago
Closed 12 years ago
Remove "getFaviconForPage" and "getFaviconDataAsDataURL" in "test_bookmarks_html.js"
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: raymondlee, Assigned: raymondlee)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #708904 -
Flags: review?(mak77)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Pushed to try. https://tbpl.mozilla.org/?tree=Try&rev=5a5aebdcb9ed
|
||
Comment 3•12 years ago
|
||
Comment on attachment 708904 [details] [diff] [review]
v1
Review of attachment 708904 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/places/tests/unit/test_bookmarks_html.js
@@ +344,5 @@
> + base64EncodeString(String.fromCharCode.apply(String, aData));
> + do_check_true(base64Icon == aExpected.icon);
> + deferred.resolve();
> + });
> + deferred.promise;
would be better to return deferred.promise explicitly here, just for clarify.
Attachment #708904 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Pushed to try and waiting for results
https://tbpl.mozilla.org/?tree=Try&rev=3b38afec565c
Attachment #708904 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 5•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•