Daniel Holbert [:dholbert] Assignee
	Description • 12 years ago

nsBlockReflowState's constructor takes a parameter "const nsHTMLReflowMetrics& aMetrics", but it never uses it.

We should just drop that parameter.

	Daniel Holbert [:dholbert] Assignee
	Comment 1 • 12 years ago

It's been unused since the reflow branch landed, actually. :)

It was used in:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsBlockReflowState.cpp&rev=3.516
...but not in:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsBlockReflowState.cpp&rev=3.517

And that commit was the reflow branch.

	Daniel Holbert [:dholbert] Assignee
	Comment 3 • 12 years ago

I also removed a redundant assignment in that constructor, while I was in the neighborhood:
  mPresContext = aPresContext;

That assignment is already done in the constructor's init list, a bit higher up.

Pushed:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/0f306bf2d17d

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/0f306bf2d17d