Closed
Bug 837563
Opened 12 years ago
Closed 11 years ago
Enable PulseAudio cubeb backend by default
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
Tracking | Status | |
---|---|---|
firefox28 | --- | fixed |
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Using PulseAudio as the default cubeb backend for Linux is the goal. The ALSA backend will remain supported and the appropriate backend will be selected at runtime based on the host machine's capabilities.
Assignee | ||
Comment 1•12 years ago
|
||
Most of this was done in bug 837564. Once that lands, all that remains is to alter the build. The build changes needed are: alter configure.in to use PulseAudio by default (and allow --disable-pulseaudio), remove PULSEAUDIO_LIBS from the libxul link, and possibly add an --enable-pulseaudio-link (or something) that does include PULSEAUDIO_LIBS in the libxul link for any other code that uses PulseAudio (WebRTC?)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•11 years ago
|
||
Let's try that again. https://tbpl.mozilla.org/?tree=Try&rev=785ab040249c
Attachment #822126 -
Attachment is obsolete: true
Assignee | ||
Comment 6•11 years ago
|
||
B2g/desktop build fix: https://tbpl.mozilla.org/?tree=Try&rev=0de93e39f89c
Assignee | ||
Updated•11 years ago
|
Attachment #822130 -
Attachment is obsolete: true
Assignee | ||
Comment 7•11 years ago
|
||
Looks good on Try. Enable PulseAudio by default in configure, remove existing -lpulse since in-tree uses dlopen libpulse when available.
Attachment #824970 -
Flags: review?(mh+mozilla)
Comment 8•11 years ago
|
||
Comment on attachment 824970 [details] [diff] [review] bug837563_v1.patch Review of attachment 824970 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +5563,5 @@ > + > +MOZ_ARG_DISABLE_BOOL(pulseaudio, > +[ --disable-pulseaudio Disable PulseAudio support], > + MOZ_PULSEAUDIO=, > + MOZ_PULSEAUDIO=1) What is this supposed to achieve, if you remove MOZ_PULSEAUDIO_LIBS?
Attachment #824970 -
Flags: review?(mh+mozilla)
Comment 9•11 years ago
|
||
Comment on attachment 824970 [details] [diff] [review] bug837563_v1.patch Review of attachment 824970 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +5563,5 @@ > + > +MOZ_ARG_DISABLE_BOOL(pulseaudio, > +[ --disable-pulseaudio Disable PulseAudio support], > + MOZ_PULSEAUDIO=, > + MOZ_PULSEAUDIO=1) Ah, saw comment 7.
Attachment #824970 -
Flags: review+
Assignee | ||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b6ea9376519
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6b6ea9376519
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Updated•11 years ago
|
Comment 12•11 years ago
|
||
If building now requires libpulse-dev to be installed, this should be added to the documentation at https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Linux_Prerequisites
Assignee | ||
Comment 13•11 years ago
|
||
(In reply to mjh563 from comment #12) > If building now requires libpulse-dev to be installed, this should be added > to the documentation Thanks for the reminder, now done.
Comment 14•11 years ago
|
||
In the future, it would be nice if you made the configure error message tell the user what they need to do to work around this error (--disable-pulseaudio in this case).
Comment 15•11 years ago
|
||
> In the future, it would be nice if you made the configure error message tell the user what
> they need to do to work around this error (--disable-pulseaudio in this case).
+1
Thanks for the PulseAudio support!
Comment 16•11 years ago
|
||
Actually, given that we have a fallback with ALSA, it shouldn't be a configure error, but a warning.
status-firefox28:
--- → fixed
Whiteboard: [qa-]
Comment 18•11 years ago
|
||
Regression: Audio permanently broken when the Pulse server restarts. Filed bug 986985.
You need to log in
before you can comment on or make changes to this bug.
Description
•