Matthew Gregan [:kinetik] Assignee
	Description • 12 years ago

Using PulseAudio as the default cubeb backend for Linux is the goal.  The ALSA backend will remain supported and the appropriate backend will be selected at runtime based on the host machine's capabilities.

	Matthew Gregan [:kinetik] Assignee
	Comment 1 • 12 years ago

Most of this was done in bug 837564.  Once that lands, all that remains is to alter the build.

The build changes needed are: alter configure.in to use PulseAudio by default (and allow --disable-pulseaudio), remove PULSEAUDIO_LIBS from the libxul link, and possibly add an --enable-pulseaudio-link (or something) that does include PULSEAUDIO_LIBS in the libxul link for any other code that uses PulseAudio (WebRTC?)

	Matthew Gregan [:kinetik] Assignee
	Comment 2 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=5bc4d535f2c2

	Matthew Gregan [:kinetik] Assignee
	Comment 3 • 11 years ago

Will see how it goes on Try before requesting review.

	Matthew Gregan [:kinetik] Assignee
	Comment 4 • 11 years ago

Let's try that again.

https://tbpl.mozilla.org/?tree=Try&rev=785ab040249c

	Matthew Gregan [:kinetik] Assignee
	Comment 5 • 11 years ago

https://tbpl.mozilla.org/?tree=Try&rev=126b301b3601

	Matthew Gregan [:kinetik] Assignee
	Comment 6 • 11 years ago

B2g/desktop build fix: https://tbpl.mozilla.org/?tree=Try&rev=0de93e39f89c

	Matthew Gregan [:kinetik] Assignee
	Comment 7 • 11 years ago

Looks good on Try.

Enable PulseAudio by default in configure, remove existing -lpulse since in-tree uses dlopen libpulse when available.

	Mike Hommey [:glandium]
	Comment 8 • 11 years ago

Comment on attachment 824970 [details] [diff] [review]
bug837563_v1.patch

Review of attachment 824970 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5563,5 @@
> +
> +MOZ_ARG_DISABLE_BOOL(pulseaudio,
> +[  --disable-pulseaudio          Disable PulseAudio support],
> +   MOZ_PULSEAUDIO=,
> +   MOZ_PULSEAUDIO=1)

What is this supposed to achieve, if you remove MOZ_PULSEAUDIO_LIBS?

	Mike Hommey [:glandium]
	Comment 9 • 11 years ago

Comment on attachment 824970 [details] [diff] [review]
bug837563_v1.patch

Review of attachment 824970 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5563,5 @@
> +
> +MOZ_ARG_DISABLE_BOOL(pulseaudio,
> +[  --disable-pulseaudio          Disable PulseAudio support],
> +   MOZ_PULSEAUDIO=,
> +   MOZ_PULSEAUDIO=1)

Ah, saw comment 7.

	Matthew Gregan [:kinetik] Assignee
	Comment 10 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b6ea9376519

	Phil Ringnalda (:philor)
	Comment 11 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/6b6ea9376519

	mjh563
	Comment 12 • 11 years ago

If building now requires libpulse-dev to be installed, this should be added to the documentation at
https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Linux_Prerequisites

	Matthew Gregan [:kinetik] Assignee
	Comment 13 • 11 years ago

(In reply to mjh563 from comment #12)
> If building now requires libpulse-dev to be installed, this should be added
> to the documentation

Thanks for the reminder, now done.

	(not currently active) Ted Mielczarek
	Comment 14 • 11 years ago

In the future, it would be nice if you made the configure error message tell the user what they need to do to work around this error (--disable-pulseaudio in this case).

	Ben Bucksch (:BenB)
	Comment 15 • 11 years ago

> In the future, it would be nice if you made the configure error message tell the user what
> they need to do to work around this error (--disable-pulseaudio in this case).

+1

Thanks for the PulseAudio support!

	Ben Bucksch (:BenB)
	Comment 16 • 11 years ago

Actually, given that we have a fallback with ALSA, it shouldn't be a configure error, but a warning.

	Ben Bucksch (:BenB)
	Comment 17 • 11 years ago

Filed bug 965653 to pass metadata to PulseAudio.

	Ben Bucksch (:BenB)
	Comment 18 • 11 years ago

Regression: Audio permanently broken when the Pulse server restarts. Filed bug 986985.