We need to measure when the app is usable by the user. For that we'll need to send an event (the moment is specific to the app) to |window| that the performance test will be able to receive. The event name can be "x-moz-perf-user-ready" amongst all apps so that the performance test can be similar. For Cost Control, it should be triggered when the user can actually manipulate the app. We should measure 2 runs for this app: - in the first run we'll measure when we arrive to the "configuration" page and can manipulate it. - in the second run the configuration should be set up in advance, and we'll measure when the user can manipulate the UI

Bug 996038 introduces new events outlining the phases of application startup. Each of these 5 events needs to be implemented.

As an FYI, this implementation needs to land in 2.0 as it is important for meeting release performance acceptance criteria. https://wiki.mozilla.org/FirefoxOS/Performance/Release_Acceptance

Hi Salva, would you give me your feedback?

Comment on attachment 8440543 [details] patch v1.0 JM, could you help Marina with the measurement of performance? Thank you.

Comment on attachment 8440543 [details] patch v1.0 I put some important comments in the Pull Request. Enough to give a r-

Also you need blocker bug 971438 to be solved it be able to ever run the tests.

Comment on attachment 8440543 [details] patch v1.0 canceling my feedback request as there are substantial comments to be addressed

Any updates on having this revised and resolved?

Hi Eli, I've update the pr and I sent you an email with the pending info, sorry for delay

Comment on attachment 8440543 [details] patch v1.0 I've update the pr after our talking, would you mind reviewing the patch? Regards

Comment on attachment 8440543 [details] patch v1.0 If I am understanding the flow correctly, things look OK from the performance side, but I would still like to have this reviewed by an owner/peer to make sure the flow is correct.

Comment on attachment 8440543 [details] patch v1.0 Salva, as owner of the App, do you mind reviewing the patch? Regards

I need some info about my comments from the performance team about: https://github.com/mozilla-b2g/gaia/pull/20546#discussion-diff-15102880 https://github.com/mozilla-b2g/gaia/pull/20546#discussion-diff-15102961 The code looks well but delaying the r+ until the feedback from Eli.

Comments on GitHub.

Comment on attachment 8440543 [details] patch v1.0 Mai, move the event in [1] and that's all. Thank you very much! [1] https://github.com/mozilla-b2g/gaia/pull/20546#discussion-diff-15102961

Master: 4c7f92ce401fcb784a2ef8a378451eaa9a9554c3

Comment on attachment 8440543 [details] patch v1.0 Requesting uplift to 2.0 as it is important for meeting our release performance acceptance criteria, comment 2. [Feature/regressing bug #]: bug 996038 [User impact if declined]: none [Describe test coverage new/current, TBPL]: Feature only triggers events for testing, no user-facing features or tests [Risks and why]: Low, as there are no user-perceived changes [String/UUID change made/needed]: n/a

v2.0: https://github.com/mozilla-b2g/gaia/commit/71c64c4a914c8d4fb1e217b2a081fbc258e34622