Talkback is showing crashes at nsPop3Protocol::CommitState [d:\builds\seamonkey\mozilla\mailnews\local\src\nsPop3Protocol.cpp line 2509] nsPop3Protocol::OnStopRequest [d:\builds\seamonkey\mozilla\mailnews\local\src\nsPop3Protocol.cpp line 604] nsOnStopRequestEvent::HandleEvent [d:\builds\seamonkey\mozilla\netwerk\base\src\nsRequestObserverProxy.cpp line 159] PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 591] PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 524] _md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 1072] nsAppShellService::Run [d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp line 418] main1 [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp line 1135] main [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp line 1429] WinMain [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp line 1447] WinMainCRTStartup() All the talkback reports are coming from Windows NT 5.0 User comments are: Comment: Weird: The mail client was in the background Comment: Just the mailnews client was open Comment: Mailnews open in the background [multiple times] Comment: scrolling through mail from POP account Comment: nothing.I believe the problem occoured because of message filters and automatic pop checking.

thanks for logging this. looks like the fix will be checking for null

sheela, could you try reproducing this one. You may look at the talkback reports to get an idea of how to reproduce this.

nominating. I am working on the fix.

we should check that the last_accessed_msg < number_of_message. This should fix the crash because in the next line we are sometimes accessing out of bounds (for example when last_accessed_msg = number_of_message)

The crash is not reproducible always. However, I want to get this checked in because it will not have any side affects and should be the right fix.

cc kazhik@mozilla.gr.jp from talkback. Do you know what you did that caused the crash ?

I just hit Get Msg button, if I remember correctly. But I'm not sure. Is nsPop3Protocol::OnStopRequest() a callback function of Stop button? It indicates the crash happened when I hit Stop button...

rs=mscott let's get this top crasher on the .9.2 radar

r=bienvenu - it's worth a try, anyway.

a=dbaron for trunk checkin (on behalf of drivers) (Will the case that used to crash work correctly, or will there still be a bug? If the latter, is there a bug covering it?)

adding PDT+

There will be no new bug introduced because the last_accessed_msg should always be less than total number_of_msgs

If the last_accessed_msg should always be less than number_of_msgs, the real problem isn't fixed with the patch. Isn't it?

What I meant was whenever last_accessed_msg is less than total number_of_msgs we need to execute that code.

fix checked in. I will mark it fixed once I see it no longer in the talkback reports

FYI this crashes is one of the topcrash in M091. Here is the detail. Stack Trace: nsPop3Protocol::CommitState [d:\builds\seamonkey\mozilla\mailnews\local\src\nsPop3Protocol.cpp line 2519] nsPop3Protocol::OnStopRequest [d:\builds\seamonkey\mozilla\mailnews\local\src\nsPop3Protocol.cpp line 605] nsOnStopRequestEvent::HandleEvent [d:\builds\seamonkey\mozilla\netwerk\base\src\nsRequestObserverProxy.cpp line 159] PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 591] PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 524] _md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c line 1072] nsAppShellService::Run [d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp line 418] main1 [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp line 1159] main [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp line 1453] WinMain [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp line 1471] WinMainCRTStartup() KERNEL32.DLL + 0x192a6 (0x77e892a6) Source File : http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/local/src/nsPop3Pro tocol.cpp line : 2519 (31567596) URL: Mozilla 0.91 Messanger (31567596) Comments: Get E-Mails (31566908) Comments: Same as last time... <ding> "New Mail" *crash* (31549558) Comments: I had left the machine on while I was away. I wasn't anywhere near the computer (31526779) Comments: reading email with one browser window open...boom! (31509885) Comments: crashed while browsing POP mail account (31509590) Comments: Heard a "ding" from a incomming mail then crash... AGAIN (31507743) Comments: reading mail again...Seem like mozilla crashes alot when replying to mail and the pressing get mail...Must be like crash number 5 or 6 in just a few days (31483019) Comments: I tried to sign in to microsoft passport (31482509) Comments: opened new browser page from "open link in new window" (31480767) Comments: just downloading mail... (31480733) Comments: dont know really... more than one window open non of them having focus. (31480318) Comments: crashed while downloading from POP account

I have just checked the fix on to trunk. So Netscape6.10B1 crashes should not count.

FYI, according to talkback the last build this showed up on was the 6/7 build. I'm going to mark fixed based on Navin's comments and this data.

*** Bug 86428 has been marked as a duplicate of this bug. ***

There has been no recent talkback reports that has been submitted so far with stack trace: nsPop3Protocol::CommitState. Last build this crash has showed up was on 6/7/13 branch builds. Since this fix got checked into trunk it does not count. Please reopen this bug if there are any talkback reports submitted for trunk builds on nsPop3Protocol. I am verifying this bug based on talkback crash report.