For customization. Need a mechanism to arrange the app icons displayed on the home screen. If there has any app needs to be located at a specific location(for example, 2nd screen, position 12), then this mechanism could adopt such requirement.

+ vendor

This feature includes the following 2 parts, Part 1 - To include apps in customization package ================================================= When customized is specified, like CUSTOMIZE=<CUSTOMIZE_PATH> make reset-gaia, we would include the apps under apps/ in customization package into the build Note: for this part, we have a discussion on: When this app customization is ready, whether we could remove all the apps under test_apps/ showcase_apps/ and dogfood_apps/, etc. and rely on this app customization entirely. See Bug 845227. Part 2 - To include apps/icons arrangement in customization package ================================================= To read in customize.json in customization package for the apps/icons arrangement in homescreen.

Pointer to Github pull-request

Comment on attachment 719418 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8376 V1 patch to include apps/external apps in customization package, Note that for now the naming for the app folder is fixed as follows: apps: <customizationPackage_Dir>/apps external apps: <customizationPackage_Dir>/external-apps Besides, for external-apps, it requires the customization package dir put in the GAIA_DIR defined in the Makefile.

Comment on attachment 719418 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8376 Patch V2 (updated on the same pull request https://github.com/mozilla-b2g/gaia/pull/8376) -- Now the build script should be able to handle both absolute path and relative path for the customization package. make CUSTOMIZE=<customization_pkg_path>

Comment on attachment 719418 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8376 failed since used CUSTOMIZE directory without app/ directory. you could use the sample[1] which posted on gaia-dev mailing list for testing [1] https://groups.google.com/d/msg/mozilla.dev.gaia/OFQ6R1mjQxQ/JWxOV6jebL0J

It seems the patch I provided here would conflict with the approach taken in Bug 848604. Need to figure out which way we want to go.

Update the summary since the homescreen icon arrangement part is done by Yuren in, Bug 846618 - applications data customization

Comment on attachment 719418 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8376 Hi Yuren, The pull request has been updated to address the following 2 issues, 1. To handle the case that if the apps or external-apps folder does not exist 2. To use %DIST% to define the path of app in homescreen.json in customization package. Thanks.

Comment on attachment 719418 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8376 Hi Rudy, I sincerely appreciate you spent a lot of time on this work, thank you. but because we are discussing to merge logical of apps & external-apps in Makefile on dev-gaia mailing list, after that we can use only one apps directory to store all apps in our customization mechanism. I would like to merge logical first because that can avoid different customziation directory architecture in serveral days even one week (it will happend if your commit land first). so hold on your commit, I will merge apps & external-apps ASAP and sorry for this inconvenience.

I wrote what we plan for this bug on mozilla wiki: https://wiki.mozilla.org/B2G/MarketCustomizations#Plan feel free to update wiki page when this feature available and I'll help to apply change when bug 848604 landed.

Comment on attachment 719418 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8376 Hi, The patch has been updated. Thanks to Yuren for his follow-up this morning. (has been integrated) Right now, for the path description in homescreen.json, it will try to find the dir in distribution package first and it cannot be found, it will try to locate the app in the Gaia folder. e.g. The following entry in homescreen.json will make the script locate the app in "GAIA_DISTRIBUTION_DIR/external-apps" first. ["external-apps", "wikipedia"]" Tim, Could you please help take a look? Thank you.

below are steps to test: 1. git clone https://github.com/telefonicaid/firefoxos-gaia-spain.git <TEF_SPAIN> 2. cd <GAIA_DIR> 3. GAIA_DISTRIBUTION_DIR=<TEF_SPAIN> make production

Comment on attachment 719418 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8376 looks good for me. f+

Comment on attachment 719418 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8376 Well done! Thank you.

Tim, Thanks for the review. Landed to Gaia master, https://github.com/mozilla-b2g/gaia/commit/068cd253c279845ed561af93f0a949a2932819c3

Nominate this as leo+ for: 1. This part is to enhance our build system to include app/external apps in customization package, it should not affect the build quality. 2. We need this patch if our partner needs their customization to include some additional apps to be included. This patch would ease their process to avoid manually copying those apps into gaia folder.

(In reply to Rudy Lu [:rudyl] from comment #20) > Nominate this as leo+ for: > > 1. This part is to enhance our build system to include app/external apps in > customization package, it should not affect the build quality. > > 2. We need this patch if our partner needs their customization to include > some additional apps to be included. This patch would ease their process to > avoid manually copying those apps into gaia folder. Our existing partners (and Leo) are already creating customized builds given current state. Given that, this is not a blocker. Feel free to renominate if you truly feel this is critical.