Closed
Bug 83841
Opened 23 years ago
Closed 4 years ago
SetValue on nsHTMLInputElement is too slow
Categories
(Core :: DOM: Editor, defect, P5)
Core
DOM: Editor
Tracking
()
RESOLVED
DUPLICATE
of bug 1346723
Future
People
(Reporter: hyatt, Unassigned)
References
Details
(Keywords: perf)
One of the big differences between SeaMonkey and WinEmbed is the time it takes
to update the location bar. On SeaMonkey I've seen this consistently take
between 20-40ms.
Drilling down into the code it looks like the expensive part is a synchronous
update to the view manager. EndUpdateViewBatch is the expensive function here.
Any reason why this has to happen synchronously? We hold up the world while we
synchronously update the location bar.
Comment 1•23 years ago
|
||
looking at
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/view/src/nsViewManager2.cpp
and
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/editor/base/nsEditor.cpp
I'm cc'ing Simon and reassigning to kmcclusk, hopefully they can give some
insight to the problem
Assignee: beppe → kmcclusk
Comment 2•23 years ago
|
||
"looks like the expensive part is a synchronous update to the view manager"
I dont know why it needs to be synchronous? Can we try changing the argument in
the call to EndUpdateViewBatch in nsEditor.cpp to NS_VMREFRESH_NO_SYNC and test
it. Making it synchronous forces painting to occur when the EndUpdateViewBatch
is called which is seldom what is wanted. The only reason I can see for making
it synchronous is if we were starving the event queue and paints were not
happening. (But that would cause other problems).
Reporter | ||
Comment 3•23 years ago
|
||
Yes, the reason I assigned this to editor and not to Kevin was that it seems
like the error here is that the call itself (in Editor code) synchronous.
Comment 4•23 years ago
|
||
Beth: Can we try changing the argument in the call to EndUpdateViewBatch in
nsEditor.cpp to NS_VMREFRESH_NO_SYNC and test it?
Assignee: kmcclusk → beppe
Comment 5•23 years ago
|
||
ok -- assigning to jfrancis, cc kin and simon (they had there fingers in there too)
Assignee: beppe → jfrancis
Priority: -- → P3
Target Milestone: --- → mozilla1.0
I agree that we shouldn't be using a synchrous paint, but there are some
platforms where changing to NO_SYNC may be problematic, for example on Linux,
gtk batches async paint requests until the system is idle, this starts to look
funny if you type fast. You'll see the caret move around (because it's drawing
directly to the screen) but none of the text you type shows up until you stop
typing. It gets even more noticeable when typing in tables. (Example the
homepage for www.mozilla.org)
Comment 7•23 years ago
|
||
Maybe editor should do different things depending on whether we're handling
typing, or en-mass setting of the editor content.
Comment 8•23 years ago
|
||
assigning to kin for now; no real won to me owning this one at this time.
Assignee: jfrancis → kin
Bulk move of mozilla1.0 bugs to mozilla.1.0.1. I will try to pull some of these
back in if I can.
Target Milestone: mozilla1.0 → mozilla1.0.1
Comment 10•22 years ago
|
||
One of the patches in 141900 makes text widgets use async reflow, painting, and
scrolling. So can I close this out now?
Comment 11•22 years ago
|
||
Marking this fixed since we now use async reflows and updates for text widgets.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 13•22 years ago
|
||
We still have bug 190147, which is about textareas. Also, I think the async
reflow/update stuff was turned off. Kin, should this be reopened?
OS: Windows 2000 → All
Hardware: PC → All
Comment 14•22 years ago
|
||
Yup.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla1.1alpha → Future
Updated•18 years ago
|
QA Contact: sujay → editor
Updated•18 years ago
|
Assignee: kinmoz → nobody
Status: REOPENED → NEW
Comment 15•4 years ago
|
||
Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.
If you have reason to believe this is wrong, please write a comment and ni :jstutte.
Severity: normal → S4
Priority: P3 → P5
Comment 16•4 years ago
|
||
We have meta bug of this issue.
Status: NEW → RESOLVED
Closed: 22 years ago → 4 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•