Closed
Bug 838461
Opened 12 years ago
Closed 12 years ago
Bagheera client failing after JSM merging
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 21
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
Due to bug 838458, when we merged JSMs in bug 836177 we accidentally broke the Bagheera HTTP client. I doubt Nightly has been submitting FHR payloads since Jan 31 because of this. #fail.
Patch forthcoming.
|
Assignee | |
Comment 1•12 years ago
|
||
The main patch is moving the rest.js inclusion. rest.js is now always Cu.imported because it isn't compatible with strict mode. This will regress memory usage slightly until we make rest.js work in strict mode.
The rest of the patch is to make RESTRequest log into BagheeraClient. I've been wanting to do this for a while and this was as good of an excuse as any.
Attachment #710488 -
Flags: review?(rnewman)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Obligatory notice to njn that this may regress heap size by compartment overhead amount until bug 838458 is resolved or until zones lands.
|
||
Updated•12 years ago
|
Attachment #710488 -
Flags: review?(rnewman) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Whiteboard: [fixed in services]
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla21
|
||
Updated•12 years ago
|
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21
|
||
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•