Closed
Bug 838464
Opened 12 years ago
Closed 12 years ago
Define MOZ_BUILD_TIMESTAMP in Fennec makefile
Categories
(Android Background Services Graveyard :: Product Announcements, defect)
Android Background Services Graveyard
Product Announcements
ARM
Android
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla21
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
Who knows which component should get this bug…
Gonna define MOZ_BUILD_TIMESTAMP in Makefile.in, using the output of Bug 838459, to implement some sanity checking in Bug 838416.
gps, you get review.
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 710491 [details] [diff] [review]
Proposed patch. v1
Review of attachment 710491 [details] [diff] [review]:
-----------------------------------------------------------------
Kinda surprised we don't have this as a regular MOZ_* variable. I guess that would be a good follow-up. Meh.
::: mobile/android/base/Makefile.in
@@ +306,5 @@
> -DUA_BUILDID=$(UA_BUILDID) \
> -DMOZ_APP_BASENAME=$(MOZ_APP_BASENAME) \
> -DMOZ_APP_BUILDID=$(MOZ_APP_BUILDID) \
> -DMOZ_APP_ABI=$(TARGET_XPCOM_ABI) \
> + -DMOZ_BUILD_TIMESTAMP=$(MOZ_BUILD_TIMESTAMP) \
spaces not tabs here
Attachment #710491 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Target Milestone: --- → mozilla21
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Component: Android: Product Announcements → Product Announcements
Product: Mozilla Services → Android Background Services
You need to log in
before you can comment on or make changes to this bug.
Description
•