Need this for bug 838614.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=a2d7d23ee48d

Try run for real: https://tbpl.mozilla.org/?tree=Try&rev=a2d7d23ee48d

Try run for real real: https://tbpl.mozilla.org/?tree=Try&rev=1ba85fe2a5dd

Comment on attachment 711092 [details] [diff] [review] part 1. Add support in Prefable for calling a function to determine whether a property should be exposed in a WebIDL binding. Review of attachment 711092 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/BindingUtils.cpp @@ +649,4 @@ > } > > static bool > XrayResolveAttribute(JSContext* cx, JSObject* wrapper, jsid id, Would it make sense to actually pass in the unwrapped object as |JSObject* obj| here too (we already do that for all the Xray* hooks)? @@ +901,5 @@ > id, desc); > } > > bool > +XrayEnumerateAttributes(JSContext* cx, JSObject* wrapper, Add |JSObject* obj| here too. @@ +924,5 @@ > return true; > } > > bool > +XrayEnumerateProperties(JSContext* cx, JSObject* wrapper, Same here. @@ +1029,5 @@ > const NativePropertiesHolder& nativeProperties = > nativePropertyHooks->mNativeProperties; > > if (nativeProperties.regular && > + !XrayEnumerateProperties(cx, wrapper, flags, props, type, Pass in obj here. @@ +1036,5 @@ > } > > if (nativeProperties.chromeOnly && > xpc::AccessCheck::isChrome(js::GetObjectCompartment(wrapper)) && > + !XrayEnumerateProperties(cx, wrapper, flags, props, type, And here. ::: dom/bindings/DOMJSClass.h @@ +69,5 @@ > + inline bool isEnabled(JSContext* cx, JSObject* obj) { > + return enabled && > + (!enabledFunc || > + enabledFunc(cx, js::GetGlobalForObjectCrossCompartment(obj))); > + Trailing whitespace.

> Would it make sense to actually pass in the unwrapped object as |JSObject* obj| here too Makes sense. I'll do that.

Comment on attachment 711093 [details] [diff] [review] part 2. Add codegen support for calling a function to determine whether a property should be exposed in a WebIDL binding. Review of attachment 711093 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/bindings/BindingUtils.cpp @@ +716,5 @@ > } > if (methods) { > Prefable<JSFunctionSpec>* method; > for (method = methods; method->specs; ++method) { > + if (method->isEnabled(cx, js::UnwrapObject(wrapper))) { If you plan to land these separately you should merge this into part 1. ::: dom/bindings/Codegen.py @@ +1049,2 @@ > return None > + # It's a list of strings Wrong indentation. ::: dom/bindings/DOMJSClass.h @@ +69,5 @@ > inline bool isEnabled(JSContext* cx, JSObject* obj) { > return enabled && > (!enabledFunc || > enabledFunc(cx, js::GetGlobalForObjectCrossCompartment(obj))); > + } Again, should probably merge this into part 1. @@ +76,5 @@ > bool enabled; > // A function pointer to a function that can say the property is disabled > // even if "enabled" is set to true. If the pointer is null the value of > // "enabled" is used as-is. > + PropertyEnabled enabledFunc; And this.

> If you plan to land these separately you should merge this into part 1. > Again, should probably merge this into part 1. > And this. Done locally when addressing the comments for part 1. Sorry I didn't post an updated part 2. :( > Wrong indentation. Fixed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/83952a3e9b74 https://hg.mozilla.org/integration/mozilla-inbound/rev/35231869058a https://hg.mozilla.org/integration/mozilla-inbound/rev/b5fa1cb51dc8 https://hg.mozilla.org/integration/mozilla-inbound/rev/20931d1439b2 https://hg.mozilla.org/integration/mozilla-inbound/rev/136477aeba1e

https://hg.mozilla.org/mozilla-central/rev/83952a3e9b74 https://hg.mozilla.org/mozilla-central/rev/35231869058a https://hg.mozilla.org/mozilla-central/rev/b5fa1cb51dc8 https://hg.mozilla.org/mozilla-central/rev/20931d1439b2 https://hg.mozilla.org/mozilla-central/rev/136477aeba1e

Documented at https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#.5BFunc.3D.22funcname.22.5D