Closed Bug 838716 Opened 12 years ago Closed 12 years ago

dist/bin/modules/commonjs/* have wrong permissions

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: glandium, Unassigned)

References

Details

All subdirectories under dist/bin/modules/commonjs/ have the executable bit missing: $ find dist/bin/modules/commonjs/ -type d -ls 14508033 4 drwxr-xr-x 4 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/ 14508034 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/toolkit 14508035 4 drw-r--r-- 27 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk 14508036 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/net 14508037 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/passwords 14508038 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/util 14508039 4 drw-r--r-- 3 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/dom 14508040 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/dom/events 14508041 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/io 14508042 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/event 14508043 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/page-mod 14508044 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/windows 14508045 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/window 14508046 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/system 14508047 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/content 14508048 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/core 14508049 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/l10n 14508050 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/tabs 14508051 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/preferences 14508052 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/lang 14508053 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/addon 14508054 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/frame 14508055 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/keyboard 14508056 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/private-browsing 14508057 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/loader 14508058 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/test 14508059 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/console 14508060 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/platform 14508061 4 drw-r--r-- 4 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/deprecated 14508062 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/deprecated/traits 14508063 4 drw-r--r-- 2 mh mh 4096 Feb 6 17:39 dist/bin/modules/commonjs/sdk/deprecated/events This makes all files under dist/bin/modules/commonjs inaccessible on OSX and Linux.
Odd, on my linux build dist/bin/modules/commonjs/sdk and dist/bin/modules/commonjs/toolkit are just symbolic links to the source which has the correct permissions. I suspect this isn't happening on tinderbox either otherwise the builds wouldn't be passing tests. Is there something special about your build config?
Ah, I had a patch making me use nsinstall.py... so it's not really a problem for default setups, but it can certainly be a problem with funky setups or in the future.
I'm guessing that whatever I do to fix bug 837915 will solve this
Depends on: 837915
Is this still a problem?
Fixed by bug 837915.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.