I'm running into multiple definitions of various classes when attempting to build the transformiix extension (on by default) into the static build per bug 46775. ../../dist/lib/components/libtransformiix.a(nsSyncLoader.o): In function `nsLoadListenerProxy::nsLoadListenerProxy(nsCOMPtr<nsIWeakReference>)': nsSyncLoader.o(.text+0x0): multiple definition of `nsLoadListenerProxy::nsLoadListenerProxy(nsCOMPtr<nsIWeakReference>)' ../../dist/lib/components/libxmlextras.a(nsXMLHttpRequest.o)(.text+0x3e8): first defined here ../../dist/lib/components/libtransformiix.a(nsSyncLoader.o): In function `nsLoadListenerProxy::~nsLoadListenerProxy(void)': nsSyncLoader.o(.text+0x48): multiple definition of `nsLoadListenerProxy::~nsLoadListenerProxy(void)' ../../dist/lib/components/libxmlextras.a(nsXMLHttpRequest.o)(.text+0x430): first defined here ../../dist/lib/components/libtransformiix.a(nsSyncLoader.o): In function `nsLoadListenerProxy::AddRef(void)': nsSyncLoader.o(.text+0x84): multiple definition of `nsLoadListenerProxy::AddRef(void)' ../../dist/lib/components/libxmlextras.a(nsXMLHttpRequest.o)(.text+0x46c): first defined here ../../dist/lib/components/libtransformiix.a(nsSyncLoader.o): In function `nsLoadListenerProxy::Release(void)': nsSyncLoader.o(.text+0x94): multiple definition of `nsLoadListenerProxy::Release(void)' ../../dist/lib/components/libxmlextras.a(nsXMLHttpRequest.o)(.text+0x47c): first defined here /usr/bin/ld: Warning: size of symbol `nsLoadListenerProxy::Release(void)' changed from 47 to 53 in nsSyncLoader.o ../../dist/lib/components/libtransformiix.a(nsSyncLoader.o): In function `nsLoadListenerProxy::QueryInterface(nsID const &, void **)': nsSyncLoader.o(.text+0xcc): multiple definition of `nsLoadListenerProxy::QueryInterface(nsID const &, void **)' ../../dist/lib/components/libxmlextras.a(nsXMLHttpRequest.o)(.text+0x4ac): first defined here ../../dist/lib/components/libtransformiix.a(nsSyncLoader.o): In function `nsLoadListenerProxy::HandleEvent(nsIDOMEvent *)': nsSyncLoader.o(.text+0x178): multiple definition of `nsLoadListenerProxy::HandleEvent(nsIDOMEvent *)' ../../dist/lib/components/libxmlextras.a(nsXMLHttpRequest.o)(.text+0x558): first defined here ../../dist/lib/components/libtransformiix.a(nsSyncLoader.o): In function `nsLoadListenerProxy::Load(nsIDOMEvent *)': nsSyncLoader.o(.text+0x1fc): multiple definition of `nsLoadListenerProxy::Load(nsIDOMEvent *)' ../../dist/lib/components/libxmlextras.a(nsXMLHttpRequest.o)(.text+0x5dc): first defined here ../../dist/lib/components/libtransformiix.a(nsSyncLoader.o): In function `nsLoadListenerProxy::Unload(nsIDOMEvent *)': nsSyncLoader.o(.text+0x27c): multiple definition of `nsLoadListenerProxy::Unload(nsIDOMEvent *)' ../../dist/lib/components/libxmlextras.a(nsXMLHttpRequest.o)(.text+0x65c): first defined here ../../dist/lib/components/libtransformiix.a(NodeSet.o): In function `NodeSet::NodeSet(void)': NodeSet.o(.text+0x0): multiple definition of `NodeSet::NodeSet(void)' ../../dist/lib/components/libgkcontent.a(nsRuleNetwork.o)(.text+0x1de4): first defined here /usr/bin/ld: Warning: size of symbol `NodeSet::NodeSet(void)' changed from 28 to 34 in NodeSet.o ../../dist/lib/components/libtransformiix.a(NodeSet.o): In function `NodeSet::~NodeSet(void)': NodeSet.o(.text+0xdc): multiple definition of `NodeSet::~NodeSet(void)' ../../dist/lib/components/libgkcontent.a(nsRuleNetwork.o)(.text+0x1e00): first defined here /usr/bin/ld: Warning: size of symbol `NodeSet::~NodeSet(void)' changed from 47 to 63 in NodeSet.o

Can we kick it off the island for now?

Fine by me. Index: configure.in =================================================================== RCS file: /cvsroot/mozilla/configure.in,v retrieving revision 1.863.2.5 diff -u -r1.863.2.5 configure.in --- configure.in 2001/06/04 03:36:44 1.863.2.5 +++ configure.in 2001/06/04 04:24:02 @@ -3439,8 +3439,8 @@ dnl Need cookie and wallet to build mozilla, this should dnl not be the case, 18352 has been filed. dnl http://bugzilla.mozilla.org/show_bug.cgi?id=18352 -MOZ_EXTENSIONS_DEFAULT="cookie wallet xml-rpc xmlextras help transformiix" -MOZ_EXTENSIONS_ALL="$MOZ_EXTENSIONS_DEFAULT irc xmlterm inspector access-builtin venkman" +MOZ_EXTENSIONS_DEFAULT="cookie wallet xml-rpc xmlextras help " +MOZ_EXTENSIONS_ALL="$MOZ_EXTENSIONS_DEFAULT irc xmlterm inspector access-builtin venkman transformiix" MOZ_ARG_WITH_STRING(extensions, [ --with-extensions Enable extensions (dirs in extensions/)],

I can easily rename nsLoadListenerProxy. NodeSet is used all over in Transformiix, it'll be quite a patch to rename it, apart from the fact that's it's a perfectly reasonable name for a class that represents a node-set!

http://lxr.mozilla.org/seamonkey/ident?i=NodeSet shows that it's a smaller patch to change the content NodeSet. Transformiix should stick with NodeSet, IMHO. Reminder: Use a prefix for new classes ;-) Axel

Chris (waterson), how about renaming NodeSet to ReteNodeSet in content/xul/templates/src? I would do such a patch, but I couldn't update the content/build/win32.order Axel

Axel: that'd be fine. Filed bug 84153.

r=peterv.

sr=jst

a=dbaron for trunk checkin (on behalf of drivers)

fix checked in, Chris, can you verify? Thanx Axel

I think we'll land the STATIC_BUILD_20010523_BRANCH soon (either to land it properly, or to re-branch). We'll see then. (Don't want to take the changes onto the branch b/c of merge conflict headaches.)

Verified with the new STATIC_BUILD_20010612_BRANCH branch.