Closed
Bug 838827
Opened 12 years ago
Closed 12 years ago
Constant only providers may not be reported in FHR payload
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 21
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
We optimized them out of serialization. #fail.
|
Assignee | |
Comment 1•12 years ago
|
||
If you have any questions, look over your right shoulder.
Attachment #711077 -
Flags: review?(rnewman)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 711077 [details] [diff] [review]
Better management of constant-only providers, v1
Review of attachment 711077 [details] [diff] [review]:
-----------------------------------------------------------------
::: services/healthreport/healthreporter.jsm
@@ +733,5 @@
>
> + throw new Task.Result(payload);
> + } finally {
> + yield this.ensureConstantOnlyProvidersUnregistered();
> + }
Need tests that:
* getJSONPayload's promise and eCOPU's promise are resolved in that order.
* eCOPU is called even if getJSONPayload throws.
|
|
Assignee | |
Comment 3•12 years ago
|
||
I think I added the test coverage you want.
Attachment #711077 -
Attachment is obsolete: true
Attachment #711077 -
Flags: review?(rnewman)
Attachment #711107 -
Flags: review?(rnewman)
|
|
||
Updated•12 years ago
|
Attachment #711107 -
Flags: review?(rnewman) → review+
|
|
||
Comment 4•12 years ago
|
||
Whiteboard: [fixed in services]
|
|
||
Comment 5•12 years ago
|
||
Mis-flagged as Bug 838227 in Greg's commit.
https://hg.mozilla.org/mozilla-central/rev/595da71ae45f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla21
|
||
Updated•12 years ago
|
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21
|
||
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•