Closed
Bug 838980
Opened 12 years ago
Closed 11 years ago
Test that context-menus are not added to private windows when they are not supported
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: mossop)
References
Details
Attachments
(1 file)
No description provided.
Priority: -- → P1
Reporter | ||
Comment 1•12 years ago
|
||
Dave can you lean on you for this one?
You'd want to start the branch off of:
https://github.com/erikvold/jetpack-sdk/tree/834961
https://github.com/mozilla/addon-sdk/pull/769
Flags: needinfo?(dtownsend+bugmail)
Reporter | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → dtownsend+bugmail
Assignee | ||
Updated•12 years ago
|
Attachment #714539 -
Flags: review?(evold)
Reporter | ||
Updated•12 years ago
|
Blocks: sdk/context-menu
Target Milestone: 1.14 → ---
Reporter | ||
Updated•12 years ago
|
Attachment #714539 -
Flags: review?(evold) → review?(rFobic)
Reporter | ||
Comment 3•12 years ago
|
||
The pull request here needs to be updated.
Comment 4•12 years ago
|
||
Comment on attachment 714539 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/794
Will wait for rebase.
Attachment #714539 -
Flags: review?(rFobic)
Assignee | ||
Updated•12 years ago
|
Attachment #714539 -
Flags: review?(rFobic)
Comment 5•12 years ago
|
||
Comment on attachment 714539 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/794
So either I don't understand what test.checkMenu does or all this tests have wrong assumptions in regard to present context menu items on private windows if loader is not created using newPrivateLoader.
Attachment #714539 -
Flags: review?(rFobic) → review-
Assignee | ||
Updated•12 years ago
|
Attachment #714539 -
Flags: review- → review?
Attachment #714539 -
Flags: review? → review?(rFobic)
Updated•11 years ago
|
Attachment #714539 -
Flags: review?(rFobic) → review+
Comment 6•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/c19f00d278fea5e93eacb83968a0bbc52c956854
Bug 838980: Test that context-menu works correctly with private browsing support. r=gozala
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•