Tom S [:evilpie] Assignee
	Description • 12 years ago

This will be easy after we removed the object equality hook.

	Tom S [:evilpie] Assignee
	Comment 1 • 12 years ago

Very simple object equality hook. This passes jit-tests, but we should maybe wait until the equality hook removal is merged.

	Kannan Vijayan [:djvj]
	Comment 2 • 12 years ago

Comment on attachment 712948 [details] [diff] [review]
v1

Review of attachment 712948 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/BaselineIC.cpp
@@ +1238,5 @@
>              stub->addNewStub(stringStub);
>              return true;
>          }
> +
> +        if (lhs.isObject() && rhs.isObject() && !stub->hasStub(ICStub::Compare_Object)) {

The |!stub->hasStub(ICStub::Compare_Object)| check can be moved into the conditional and made into an ASSERT.

If we've attached a Compare_Object stub, then we should never hit the fallback stub when both lhs and rhs are objects.

	Tom S [:evilpie] Assignee
	Comment 3 • 12 years ago

https://hg.mozilla.org/projects/ionmonkey/rev/39662d8948a6