** Observed with 6/1/2001 Win32 Branch build ** 1.Open a new HTML eidtor document. 2. Type in a few lines. Then start a new line as follows: a. At this point, the text is set to "Body Text". b. Now CTRL+B (=turn on 'Bold' style.) b. Type in something like: "How:" and then insert a newline (CR/LF) c. Now try to create a list by clicking on the "bullet" or "number" button. 3. Instead of creating the list, the cursor resets to the end of the previous line. The problem does not happen, if step (b) is omitted. I think this is a bug that impairs basic functionality a lot of people use.

one problem here is that a list is not allowed within an inline element. We would have to end the bold element at this point and then open the list. Granted we should not jump back up to the previous line. Assigning to Joe and setting to 1.0

cc joe remove milestone for reconsideration. This bug is going to affect user perception of doing lists. This seems like a regression to me. We should be inserting the list and a bold node inside of it. If we aren't going to the right things under the covers, then we should disable the options to insert a list.

can't pull this in to 9.2, but will put it in 9.3

this should be assigned to joe

reviewed and approved

*** Bug 87915 has been marked as a duplicate of this bug. ***

marking QAHP.

the attached patch fixes bug 83918 bug 62347 bug 86476 bug 87882 need r=; sr=; testing

-nsresult -nsEditor::GetLeftmostChild(nsIDOMNode *aCurrentNode, nsIDOMNode **aResultNode) +nsCOMPtr<nsIDOMNode> +nsEditor::GetLeftmostChild(nsIDOMNode *aCurrentNode, PRBool bNoBlockCrossing) I'm not at all keen on this change, for this reason (thanks to scc!): nsIDOMNode* node = GetLeftmostChild(...) compiles, but leaks, with this method signature. scc suggests: already_AddRefed<nsIDOMNode> nsEditor::GetLeftMostChild(...) or, of course, the normal nsIDOMNode* out param method.

Missed 0.9.3.

clearing the nsbranch keyword so as not to be confused with the current set of nsbranch bugs.

checked in. Kin investigated using the change Simon suggests, and there were problems (crashes). So for now I'm just doing what I did originally: returning comptr's. This will only leak if a seperate programming error is made, so it should be ok for now. It would be nice to improve it later to make it safer.

verified in 8/31 build.