Closed
Bug 839236
Opened 12 years ago
Closed 12 years ago
Plugin Hang UI: Missing nsRefPtr in PluginModuleParent::GetPluginName
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla21
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
While running my new unit tests in bug 826851, I found leakage due to a missing nsRefPtr.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #711487 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Rev 2, removes some extra stuff that shouldn't have been in there
Attachment #711487 -
Attachment is obsolete: true
Attachment #711487 -
Flags: review?(benjamin)
Attachment #711488 -
Flags: review?(benjamin)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 711488 [details] [diff] [review]
Adds missing nsRefPtr to nsPluginHost::GetInst call Rev. 2
Review of attachment 711488 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/plugins/ipc/PluginModuleParent.cpp
@@ +533,5 @@
> bool
> PluginModuleParent::GetPluginName(nsAString& aPluginName)
> {
> + nsRefPtr<nsPluginHost> host =
> + already_AddRefed<nsPluginHost>(nsPluginHost::GetInst());
You could use |dont_AddRef(nsPluginHost::GetInst())| here instead.
|
||
Comment 4•12 years ago
|
||
Comment on attachment 711488 [details] [diff] [review]
Adds missing nsRefPtr to nsPluginHost::GetInst call Rev. 2
Yeah, use dont_AddRef here. r=me with that
Attachment #711488 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Carrying forward r+
Try build is https://tbpl.mozilla.org/?tree=Try&rev=a49d1a6c54f6
Attachment #711488 -
Attachment is obsolete: true
Attachment #712655 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 6•12 years ago
|
||
Keywords: checkin-needed
|
||
Comment 7•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•