Closed
Bug 839272
Opened 12 years ago
Closed 11 years ago
Re-enable WebRTC when bug 837618 is fixed
Categories
(Thunderbird :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 24.0
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
(deleted),
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
Bug 839046 temporarily disabled WebRTC as a work around for bug 837618.
Once bug 837618 is fixed, we should re-enabled WebRTC as it is something extensions might want to use.
Note: when we re-enable, we need to do more than backing out bug 839046 - we need to add the required parts to packaging as well, as currently not everything is packaged that is needed for WebRTC.
Assignee | ||
Comment 1•11 years ago
|
||
This enables webrtc, and has the side effect of fixing the bustage on trunk.
Updated•11 years ago
|
Attachment #765418 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
Comment 3•11 years ago
|
||
Just a small headsup - this breaks packaging on platforms where webrtc is not enabled (ie the BSDs) because peerconnection files are not guarded within #ifdef MOZ_WEBRTC in mail/installer/package-manifest.in. Testing an obvious fix here, then will post a follwup patch for review.
Comment 4•11 years ago
|
||
Fixes the issue here, thunderbird-24.0a1.en-US.openbsd5.3-x86_64.tar.bz2 is fine with that diff
Attachment #766314 -
Flags: review?(mbanner)
Assignee | ||
Updated•11 years ago
|
Attachment #766314 -
Flags: review?(mbanner) → review+
Assignee | ||
Comment 5•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•