Closed
Bug 839319
Opened 12 years ago
Closed 12 years ago
Switch to WAVE_FORMAT_EXTENSIBLE for all formats in cubeb winmm backend
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
Attachments
(1 file)
(deleted),
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
While working on bug 837430, I discovered the WAVE_FORMAT_EXTENSIBLE path was broken because wValidBitsPerSample was not initialized correctly.. Once it was, it was clobbered by later zero-initializations of wSamplesPerBlock and wReserved, which are part of the same union.
With that fixed, WAVE_FORMAT_EXTENSIBLE works, so we might as well use it exclusively and remove a conditional. This also enables multichannel audio to work with WinMM, but more work needs to be done (in bug 521615) to map Vorbis channel layouts to Wave channel layouts.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Attachment #711605 -
Flags: review?(chris.double)
Updated•12 years ago
|
Attachment #711605 -
Flags: review?(chris.double) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•