Open Bug 83934 Opened 24 years ago Updated 2 years ago

Move layout tests out of layout/

Categories

(Core :: Layout, defect)

defect

Tracking

()

People

(Reporter: bryner, Unassigned)

Details

(Whiteboard: [awd:tbl])

The HTML testcases (layout/html/tests) represent a sizeable amount of disk footprint (and download time, if you're on a slow connection), and most people will never need to look at these. I propose moving them to a new toplevel directory which is not in the default pull.
bryner, is this something you can do? I can so no valid reason why it shouldnt happen as you say.
Whiteboard: [awd:tbl]
Temporarily moving to future until a milestone can be assigned.
Status: NEW → ASSIGNED
Target Milestone: --- → Future
mass reassign to default owner
Assignee: karnaze → table
Status: ASSIGNED → NEW
Component: Layout → Layout: Tables
QA Contact: petersen → madhur
Target Milestone: Future → ---
back to layout
Assignee: table → other
Component: Layout: Tables → Layout
QA Contact: madhur → ian
I just looked at my disk from 186MB source files 12.2 MB are inside layout/html/tests When searching for test on I found 26.9MB of files. I propose to create a new toplevel directory tests to move the files contained in the testdirectories there while removing the trailing test in the directory path. to pull those files only when ENABLE_TESTS is defined If one would further put those files on a different partition one could give QA people write access to this directory, while they could not access the main code repository.
ENABLE_TESTS seems like the wrong thing. It should probably just require a separate pull. The big issue here isn't the size of the files, but the number of (very small) files, which slows cvs operations down.
I propose to: 1. create a subdirectory rtest under tools 2. move the tests from html/tests there to my knowledge tools http://lxr.mozilla.org/mozilla/source/tools/ is not pulled by default, people who run these tests will be able to make a additional pull. If this is OK I would just commit the files to the new directory and remove html/tests. I don't think we need the cvs history.
We do want the cvs history, if only from a repository-copy.
Is this something we would want to consider for other tests in the tree? Why name the subdirectory "rtests"? Would that play well with others if other test suites were moved to tools?
http://lxr.mozilla.org/mozilla/source/tools/tests/ is already occupied with some strange stuff. but tools/testcases/ as main directory and then layout/html below for the current regression tests should be fine and js could be parallel to layout tools testcases layout html js . .
Assignee: layout → nobody
QA Contact: ian → layout
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.