Closed
Bug 839352
Opened 12 years ago
Closed 12 years ago
B2G SMS & B2G MMS: clean up the chaotic terminology for |record| and |message| in MobileMessageDatabaseService.js
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
People
(Reporter: airpingu, Assigned: airpingu)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
vicamo
:
review+
|
Details | Diff | Splinter Review |
The terminology is a chaos. Sometimes we use |message|, |record| and |data| to refer to the same thing but they actually have different meanings. I hope to clean them up first so that it's easier to do the following tasks for constructing the MMS database.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #711659 -
Flags: review?(mounir)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #711659 -
Attachment is obsolete: true
Attachment #711659 -
Flags: review?(mounir)
Attachment #711666 -
Flags: review?(mounir)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 711666 [details] [diff] [review]
Patch, V1.1
Review of attachment 711666 [details] [diff] [review]:
-----------------------------------------------------------------
r=me instead.
Attachment #711666 -
Flags: review?(mounir) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
|
Assignee | |
Comment 6•12 years ago
|
||
This bug relates to MMS features and needs to be tagged as leo+ so that we can uplift it into the b2g-18 branch.
blocking-b2g: --- → leo?
|
|
||
Comment 8•12 years ago
|
||
unable to find 'dom/mobilemessage/src/ril/MobileMessageDatabaseService.js' for patching
14 out of 14 hunks FAILED -- saving rejects to file dom/mobilemessage/src/ril/MobileMessageDatabaseService.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 839352
|
|
Assignee | |
Comment 9•12 years ago
|
||
This one depends on Bug 831683, which needs to be checked in first.
Depends on: 831683
|
|
Assignee | |
Comment 10•12 years ago
|
||
status-b2g18:
--- → fixed
status-firefox21:
--- → fixed
|
|
||
Updated•12 years ago
|
status-b2g18-v1.0.0:
--- → wontfix
status-b2g18-v1.0.1:
--- → wontfix
status-firefox20:
--- → wontfix
|
||
Updated•11 years ago
|
Flags: in-moztrap-
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•