Panos Astithas (he/him) [:past] (please ni?) Assignee
	Description • 12 years ago

Sometime the past few days the fonts in the remote connection screen (the one you get from the 'Connect...' menu item became really small. It is very evident in the host/port labels, but also in the target list after one connects to a remote instance.

My guess is that this is a regression from bug 826685, so CCing Paul and Mihai.

	Girish Sharma [:Optimizer]
	Comment 1 • 12 years ago

Attached the URL for the screenshot of the small font on connect screen.

	Girish Sharma [:Optimizer]
	Comment 2 • 12 years ago

URL for the target list : http://i.imgur.com/YqWZ7e2.png?1

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 4 • 12 years ago

My new glasses didn't improve the situation, so I really had to fix this, otherwise the connection screen was barely usable for me.

Tested on Lion, Mountain Lion, Ubuntu 12.10, Windows 7 and Windows XP: in all cases there was an improvement. Besides the tiny font, OS X has large round borders in the input box which need to be accompanied with larger horizontal padding.

	Victor Porof [:vporof][:vp]
	Comment 7 • 12 years ago

I though the extra large inputs were just a side effect of the font size. They look kinda' funky to me.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 8 • 12 years ago

(In reply to Victor Porof [:vp] from comment #7)
> I though the extra large inputs were just a side effect of the font size.
> They look kinda' funky to me.

They don't feel that large in all operating systems, actually. My guess is that Paul tried to fill the large empty space somehow.

I'd rather not make non-obvious fixes/changes in this bug, though. Let's file followups for more UI tweaks.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 9 • 12 years ago

https://hg.mozilla.org/integration/fx-team/rev/66ed95d19a69

	Victor Porof [:vporof][:vp]
	Comment 10 • 12 years ago

https://hg.mozilla.org/mozilla-central/rev/66ed95d19a69

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 11 • 12 years ago

This is the rebased patch for mozilla-beta.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 12 • 12 years ago

Comment on attachment 735052 [details] [diff] [review]
Patch for beta

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 826685
User impact if declined: the remote connection screen and the remote targets list screen will have tiny fonts, making them barely usable to visually impaired people
Testing completed (on m-c, etc.): m-c, beta
Risk to taking this patch (and alternatives if risky): insignificant risk, styling changes only, in a single tab that will be used by web developers after flipping a pref (devtools.debugger.remote-enabled)
String or IDL/UUID changes made by this patch: none

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 13 • 12 years ago

Comment on attachment 732737 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 826685
User impact if declined: the remote connection screen and the remote targets list screen will have tiny fonts, making them barely usable to visually impaired people
Testing completed (on m-c, etc.): m-c, aurora locally
Risk to taking this patch (and alternatives if risky): insignificant risk, styling changes only, in a single tab that will be used by web developers after flipping a pref (devtools.debugger.remote-enabled)
String or IDL/UUID changes made by this patch: none

	bhavana bajaj [:bajaj]
	Comment 14 • 12 years ago

Comment on attachment 735052 [details] [diff] [review]
Patch for beta

low risk, polish only.Approving for aurora,beta.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 15 • 12 years ago

https://hg.mozilla.org/releases/mozilla-beta/rev/8ac5f560ac98
https://hg.mozilla.org/releases/mozilla-aurora/rev/f22b5313db35

	Ioana (away)
	Comment 16 • 12 years ago

Verified as fixed on Firefox 21 beta 3 - 20130416200523.

	Ioana (away)
	Comment 17 • 12 years ago

While trying to verify this fix on Firefox 22, I noticed the following: although I set devtools.debugger.remote-enabled to true and restart Firefox, I don't get the remote debugger option in the Tools menu anymore (nor anywhere else). Is this expected? Is there another way I can get to the connect dialog?

	Girish Sharma [:Optimizer]
	Comment 18 • 12 years ago

To get the "Browser Debugger", you also need devtools.chrome.enabled since Browser Debugger runs in a separate process and is not simply a remote tool, like Style editor or profiler.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 19 • 12 years ago

(In reply to Ioana Budnar, QA [:ioana] from comment #17)
> While trying to verify this fix on Firefox 22, I noticed the following:
> although I set devtools.debugger.remote-enabled to true and restart Firefox,
> I don't get the remote debugger option in the Tools menu anymore (nor
> anywhere else). Is this expected? Is there another way I can get to the
> connect dialog?

Yes, both Remote Debugger and Remote Console have been replaced by the 'Connect...' menu item mentioned in comment 0.

	Ioana (away)
	Comment 20 • 12 years ago

It's the "Connect" item I was referring to. For some reason it didn't show up until I restarted Firefox several time. I'm not sure what happened there, but I can't seem to reproduce it again.

I did verify this bug as Fixed on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:21.0) Gecko/20100101 Firefox/22.0 - 20130514181517.